#4250 - Failure finishing sending notifications on some server/Composr configurations

Identifier #4250
Issue type Trivial issue (does not break functionality)
Title Failure finishing sending notifications on some server/Composr configurations
Status Completed
Handling member Chris Graham
Version 10.0.30
Addon core_notifications
Description If:
- The "Use a task queue" config option is off (the default)
- CGI timeout is turned on in server settings
- Lots of notifications are going to send
- Sending an e-mail through the server sendmail backend is slow / SMTP e-mail is enabled
(the last 3 points correspond - shorter timeout means less time to send each email - more emails means longer timeout needed, etc etc)

Mail will not finish sending.
As tasks are run at the end of the main page view that triggers the task (a notifications task in this case), the user will not see any timeout happening. And because it's a CGI-triggered timeout, PHP doesn't log any kind of error either.

Enabling the task queue resolves the issue as tasks will be processed via Cron in an orderly way rather than in the web request that originally triggers them.

This fix will make it so that if the task queue is not enabled then the e-mails are queued rather than being instantly sent out.
i.e. if one queue is not enabled, it enforces the other
Steps to reproduce

Funded? No
Commits

Fixed MANTIS-4250 (Failure finishing sending notifications on some server/Composr configurations) (55b8cfce) · Commits · Composr ecosystem / Composr · GitLab

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated