#4037 - main_cc_embed issue
| Identifier | #4037 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | main_cc_embed issue |
| Status | Closed (no changes needed) |
| Handling member | Chris Graham |
| Addon | core |
| Description | I moved some of my catalogue entries into categories and they now fail to show in the block unless I select a category exclusively. I imagined they would show as normal (as with narrow in when browsing) so perhaps this is a bug? |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
If you want to embed from multiple categories, you need to use the Selectcode parameter, to override the category ID passed.
The narrow in config option is for the module. Generally it's expected a link from a block won't link back to the same page the block is on with the block being different. Blocks are generally not considered a primary user interface component, they're an interface into some other part of the system.
Hence, most people will not want to show all entries from subcategories under one listing.
Further, the block literally is "catalogue category embed", so it's baked into the name already.
Also, the block doesn't have a catalogue name parameter. It gets the catalogue name from the category supplied. So if we made it by default to show entries from all categories we'd want to change it to take a catalogue name instead of a category name. But then for the case of someone wanting the current behaviour, these users would then need to be supplying both a catalogue name and a category name. And then there's the consideration of what happens if someone specifies a catalogue name and then a category ID from a different catalogue (probably we'd just throw an error, but it's a further consideration).
I think the only resolution would be to create a second block. But that's expanding the scope of the product (bloat), for a use case that can already be achieved with a little more work.
Thus, I have just documented it better:
https://gitlab.com/composr-foundation/composr/commit/c5359df4c8be36597b8c19856532564373bb2aab