#3859 - Commandr 'edit' command working

By Chris Graham
Added 27th Jul 2019, 12:00 PM
2 views

Identifier	#3859
Issue type	Feature request or suggestion
Title	Commandr 'edit' command working
Status	Completed
Handling member	Salman
Addon	General / Uncategorised
Description	If you do something like... edit /etc/privacy_fax And save, it doesn't do the AJAX save. This seems to be because the JS template ($cms.templates.commandrEdit) is not applied to the COMMANDR_EDIT.tpl code when it's put into the command line.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 28th Jul 2019, 12:22 PM

Fixed in both 'v11'[1] and 'v11_redesign'[2]. Sorry about that. The Commandr command JS code wasn't using any of $dom.* insertion functions ($dom.append() etc.) at any point so there was no opportunity to attach behaviors ([data-tpl="foo"] etc.).

1: https://github.com/ocproducts/composr/commit/f1337d8a24a07fde31d39cae7a80427a228e73f3
2: https://github.com/ocproducts/composr/commit/32960f143044d670fda1b93697c332c122224109

#3859 - Commandr 'edit' command working

Rating

Comments

Statistics