#3523 - Should not use $PAGE_LINK symbol in JS
-
By Chris Graham
- Added
- 4 views
| Identifier | #3523 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Should not use $PAGE_LINK symbol in JS |
| Status | Completed |
| Handling member | Salman |
| Addon | General / Uncategorised |
| Description | facebook_support.js is using $PAGE_LINK.
However, $PAGE_LINK will propagate keep_* variables, including URL-based session IDs. Right now those will be written into the shared JS cache. These URLs need to be coming through to the JS via data-attributes. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
link: '{$PAGE_LINK;,:privacy}',
fauxmodal_alert('{!chat:_FAILED_TO_OPEN_POPUP;,{$PAGE_LINK*,_SEARCH:popup_blockers:failure=1,0,1}}',null,'{!chat:FAILED_TO_OPEN_POPUP;^}',true);
That one is fine. It shouldn't need keep propagation for an exceptional event in the chat system. a) Chatters are unlikely to be missing session cookies b) It's so exceptional I wouldn't want it to have to go through a data attribute.