#3448 - Fix template_previews test

Identifier #3448
Issue type Feature request or suggestion
Title Fix template_previews test
Status Completed
Handling member Salman
Addon General / Uncategorised
Description The template_previews test is failing on at least 2 issues...

1) Menu templates have been altered to include images and link text under the same <a> tag. This will always show an underline in the gap. This will need resolving in some way, e.g. using CSS background images with padding, or just doing what we did before (2 <a> tags).
Once this is fixed re-enable the XHTML_A_SPACES check in sources/webstandards2.php

2) <script type="text/html" in BLOCK_MAIN_IMAGE_FADER_NEWS.tpl is breaking the validator code badly.
The validator code will probably need some changes to make it not apply the same validation rules to text/html. That said, I believe validators will see <script> as CDATA, and that means you're supposed to use CDATA escaping of closing tags in there, which isn't happening here. Make sure that real HTML5 validators don't fail on your current HTML.

There may be other issues, but I'm stuck at these right now.
Steps to reproduce

Additional information It's important the web standard checks continue to work, as this is how we make sure we maintain code validation across the ~ 1000 templates - if our code doesn't validate, that will be seen very negatively by a subgroup of people (and manual validation of 100s of screens each release isn't viable).
So please run this test after making heavy changes to make sure things aren't breaking.
Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated