#3322 - Cleanup broken URL APIs
-
By Chris Graham
- Added
- 4 views
| Identifier | #3322 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Cleanup broken URL APIs |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | Chris Graham |
| Addon | core |
| Description | We have:
- test_url [for Comcode] - handle_has_checked_recently (uses url_title_cache table) - check_url_exists (uses urls_checked table) - check in broken URL API Possibly these can be merged into a single API, using a single table. It should offer good default functionality. It should be able to store HTTP responses in the table. It should be able to have "only cache if 200 status" functionality (i.e. cache on success, re-try on failure). |
| Steps to reproduce | |
| Related to | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Should be different health checks for local URLs, remote URLs, and the other options currently handled in admin_broken_urls."
EDIT: No, because false-positives will happen.
So the broken URL checking needs to handle 403 (and probably 401) as not failures. Perhaps make the checks smarter than binary fails/works, with support for a few different response categories, and include this information in the check results.