#3219 - Comcode page children issues
-
By Adam Edington
- Added
- 5 views
| Identifier | #3219 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Comcode page children issues |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | core_comcode_pages |
| Description | The first issue is in the codename for child pages (which 'has' to be numbers and letters). The codename of my first page was map1-1, which shows up in the list of children but fails to link to the page. I then tried map1_1 (as I was sure the underscores used to be allowed) and got the same result as above. If it's strictly alphanumeric then maybe a check of the codename before accepting it would be useful.
My third attempt was map1x1, which I managed to link to. However the h1 of all the comcode pages has ended up sharing space with the breadcrumbs. Maybe I need to enable the setting for comcode page hierarchy, but for a new user this might be confusing. Certainly the codename for pages shouldn't accept characters the link URL doesn't like. |
| Steps to reproduce | |
| Additional information | Git install from about 2 weeks ago. |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
(Click to enlarge)
As for breadcrumbs, if fixed width is off there's more space so the CSS is coded to put them side-by-side with title.
It's always been tricky as what is best really depends on the site, if it has panels, the length of titles, the breadcrumb depth.
In global.css
.global_breadcrumbs {
padding: 7px 0 7px 0;
/*{+START,IF,{$NOT,{$MOBILE}}}*/
/*{+START,IF,{$CONFIG_OPTION,fixed_width}}*/
text-align: {!en_right};
/*{+END}*/
/*{+START,IF,{$NOT,{$CONFIG_OPTION,fixed_width}}}*/
float: {!en_right};
/*{+END}*/
margin-left: 0.5em;
/*{+END}*/
}
change to
.global_breadcrumbs {
padding: 7px 0 7px 0;
/*{+START,IF,{$NOT,{$MOBILE}}}*/
text-align: {!en_right};
margin-left: 0.5em;
/*{+END}*/
}
Templates:
BREADCRUMB_LINK_WRAP, BREADCRUMB_LONE_WRAP
{LABEL*}
-->
{$PREG_REPLACE,:.*$,,{LABEL*}}
I wouldn't want to do by default. People may have multiple pages in a hierarchy sharing a prefix intentionally.