#3044 - More robust flow through payment gateways

Identifier #3044
Issue type Feature request or suggestion
Title More robust flow through payment gateways
Status Completed
Handling member Chris Graham
Addon ecommerce
Description Currently we pass either an item name & product ID through a payment gateway, or a trans expecting ID which then let's us find the item name & product ID from the ecom_trans_expecting table.

We should consistently move to the latter, with sometimes an item name going through as a *label* only.

This has 4 advantages:
1) We can replace the 'search' method for finding products within hooks using item names to a simpler handles_product method. This is more efficient and easier to understand.
2) If the price changes mid-purchase we can rely on the ecom_trans_expecting record to have locked in the original price, avoiding an error.
3) Consistent. All hooks would do it in one way.
4) We don't have to worry about item names being unique, only the product codenames would need to be.

A ecom_trans_expecting record would only be valid for a configured length of time, default to 2 weeks. Beyond that an error message would show.
Steps to reproduce

Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated