#2851 - change detection AJAX breakage

By PDStig
Added 3rd Oct 2016, 7:33 AM
2 views

Identifier	#2851
Issue type	Minor issue (breaks specific functionality)
Title	change detection AJAX breakage
Status	Closed (cannot reproduce)
Handling member	Chris Graham
Addon	core
Description	Sometimes, especially after a refresh from change_detection.php's returning '1', the AJAX will stop executing change_detection.php (aka. cease the window refresh timer), stopping the checks for changes.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 3rd Oct 2016, 3:22 PM

Actually this happens when someone has clicked inside a quick reply or reply box. Otherwise, it continues to refresh fine.

By Guest posted 3rd Oct 2016, 3:34 PM

This also happens all the time with feedback/comments. Those always break the AJAX refresh when change_detection returns 1, and also fails to refresh the changes.

For the forums, it will successfully refresh on a change and continue checking for changes until you click in the quick reply box.

Additional info: I'm using custom change_detection hooks for the topicview and for the feedback. Only one for tickets currently exists, and that one is glitchy as well. The tickets change detection always returns 1, meaning it always thinks there's a change.

By Guest posted 3rd Oct 2016, 4:05 PM

I am trying to follow this, but the original report was corrected in a note, then it is talking about custom code, while the only non-custom code involved apparently does something different to the original report which I can't reproduce.

By Guest posted 3rd Oct 2016, 4:06 PM

"Actually this happens when someone has clicked inside a quick reply or reply box. Otherwise, it continues to refresh fine.
" - this is by design, so that replies are not lost.

By Guest posted 3rd Oct 2016, 4:07 PM

I think probably there was no bug here, but an unneeded 'fix' in #2850 actually caused the issue.

#2851 - change detection AJAX breakage

Rating

Comments

Statistics