#2640 - Attempting to use filtercode results in server hang
-
By PDStig
- Added
- 1 view
| Identifier | #2640 |
|---|---|
| Issue type | Major issue (breaks an entire feature) |
| Title | Attempting to use filtercode results in server hang |
| Status | Closed (cannot reproduce) |
| Handling member | Chris Graham |
| Addon | core |
| Description | When attempting to construct and use filtercode in any block, it causes the server to hang when Composr is (probably) trying to parse the filtercode. This prompts a necessary restart of Apache and NGINX to re-stabilize. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Composr turns on a 60 second execution limit for pages. There are a few cases where we turn it off, but it should not be the case for evaluating a block.
I just tested a main_news block with "title=foo", no issue. If you want to try and give a reproduction case, I suggest using the block construction assistant and see if you can find something that crashes when you preview it.
Parsing issue is very unlikely as it's a simple explode command:
$filters = explode((strpos($filter, "\n") !== false) ? "\n" : ',', $filter);
foreach ($filters as $bit) {
rather than a byte-by-byte loop (a byte by byte loop could potentially be buggy).
I'm not saying there's no issue, but certainly I can't reproduce one now, and if there is it's probably some kind of performance degradation that causes request queueing, rather than than any single request crashing a server.