#2576 - Automated install.php removal

By Chris Graham
Added 6th May 2016, 4:48 PM
4 views

Identifier	#2576
Issue type	Feature request or suggestion
Title	Automated install.php removal
Status	Completed
Handling member	Chris Graham
Addon	installer
Description	We do not need to warn about deleting install.php IF we are on a SuEXEC server. We can delete directly when global2.php detects it there (assuming dev mode isn't on, in which case we leave it alone).
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 26th Oct 2016, 8:09 PM

Crap this is already resolved. I was gonna say may wish to think about this one. Some CMS systems feel it is ideal to leave the installer in place and require the user to remove it themselves. That way, if the user wants to make a copy of the installer, they can. Or, if they want to use it for a later time, they can. Some systems will also keep the installer but lock it down.

By Guest posted 26th Oct 2016, 8:12 PM

I am happy with it though. I did think maybe they'd want to go back, but on balance I thought this best. Tidiness is better. Locking is extra complexity for the user. Re-upload is easy.

There is a safeguard. The installer only deletes if you follow the link at the end of the installer. That link includes a "safe to delete flag". That way tangential calls to index.php are non-destructive.

By Guest posted 26th Oct 2016, 8:19 PM

Ahh okay that's good. I thought it was automatic as in the user didn't really have a choice.

By Guest posted 26th Oct 2016, 8:21 PM

Well they don't have a choice, just it's part of the designed flow, rather than any other arbitrary other flow.

#2576 - Automated install.php removal

Rating

Comments

Statistics