#2292 - Refactor http_download_file function

Identifier #2292
Issue type Feature request or suggestion
Title Refactor http_download_file function
Status Completed
Tags

Risk: Core rearchitecting (custom)

Handling member Chris Graham
Addon core
Description This function is very long, and takes too many parameters.

Break it down into a class, with a simple frontend function to call it.

Turn some of the more exotic parameters that exist now into parameters via a map array parameter.

Make sure remaining parameters are in a logical order.

Stop using globals, make them properties that can be read by code that instantiates the class (i.e. not using the wrapper function).

Rename the wrapper function to cms_http_request.
Steps to reproduce

Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated