#2286 - Composr 10b4: Template editor creates recursive [templates]_custom... folders
-
By PDStig
- Added
- 1 view
| Identifier | #2286 |
|---|---|
| Issue type | Major issue (breaks an entire feature) |
| Title | Composr 10b4: Template editor creates recursive [templates]_custom... folders |
| Status | Closed (cannot reproduce) |
| Handling member | Chris Graham |
| Addon | core_themeing |
| Description | Say if I edit a regular template file via. the template editor. It will save it under templates_custom. That's expected behavior.
However, say if I edit a template from templates_custom. The editor will then save it in a folder called templates_custom_custom instead of where it should (templates_custom). And if I edit a templates_custom_custom file, it will add another _custom at the end of the folder name... and continue for virtually infinity. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
https://github.com/ocproducts/composr/commit/d1944e9556bed0d289f55e8aab094278be70fc05
In order:
1) The first is a real but tiny bug, broken breadcrumbs on the "do next" screen after editing a template
2) The second is related to the only cause I could think, which is a possible hole in the logic that customises the path. I can't think of how this would fail in practice though.
3) The 3rd is making sure the MAIL.tpl editing link includes "templates/" on the front, which is a new convention in v10.