#2156 - Identification of what a theme file was built from
-
By Chris Graham
- Added
- 10 views
| Identifier | #2156 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Identification of what a theme file was built from |
| Status | Open |
| Handling member | Deleted |
| Addon | Build tools |
| Description | When we make a theme in Composr, we have .editfrom files for each individual overridden file. This is a copy of the full file an override is from, allowing easy diffing even if the original file is changed in a newer version.
We do not explicitly store the version. We do need to know the version though. I suggest we start maintaining data/theme_signatures/<checksum>.json files that let us recognise what version a .editfrom file comes from. e.g. data/theme_signatures/54fgretg4g.json: {file: 'global.css', version: '10.1.1'} Most files wouldn't change between releases. However, we can just bump forward the signature file to the latest version it is equivalent to. E.g. if 10.1.2 global.css is the same as the 10.0.1 global.css, the build tools would simply replace as: data/theme_signatures/54fgretg4g.json: {file: 'global.css', version: '10.1.2'} (it can do this naively, it just replaces everything it finds a current checksum for). We can use md5 for the checksums, but we must strip all whitespace before running md5, as this may get borked outside our control (we don't remove the whitespace from the actual files of course). |
| Steps to reproduce | |
| Related to | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments