#1841 - Couple of issues with password reset
| Identifier | #1841 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Couple of issues with password reset |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | core_cns |
| Description | When attempting to reset password the following screen isn't being displayed correctly. It is also telling me KingBast is not an active username after turning on the check on new IP setting thing. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
(Click to enlarge)
All I can think is you had some DB corruption on some level.
Please state an exact sequence of events, and paste full/exact error messages. I think you are saying you turned on IP validation, then you presumably logged out at some point, then back in at some point, then were asked to do an IP validation, and got an email about that, then presumably clicked the link. Then I wonder if you logged back out again, or somehow found your way to the reset password screen by other means. But I'm very unclear on this.
Current lack of clarity include:
- How you got to the reset password screen, if you had been asked to confirm your IP address (it should lock you out, and I don't think a logout button shows). Maybe you used another browser, maybe incognito mode, I'm not sure.
- What exactly the "not active" error is (there's no case of these words being used together to refer to a user account state in our language strings, I just did a search). I can't think of any error message we have regarding it either, and the IP validation is not turned to account approval (it's a very localised check that only runs at log in / cookie log in).
- If "below the window" in fact means "below the overlay", and is referring to the overlay in the attached screenshot (the window would be the browser window itself, overlays aren't actually windows, e.g. not draggable)
- What the error message in the overlay is (I realise it looks like a big blob of HTML, but there's likely an error message buried in it, if you could paste the whole text here I could find it)
I wasn't able to capture the whole message in the screenshot, I just assumed it was a valid overlay that had displayed incorrectly. Cannot really reproduce it unless my IP changes again, which is bound to happen before too long.
That's a cool idea. I just implemented support for us showing the target mail when a reset is made, or a masked version of it (e.g. [email protected]) for me.
However we'll have to leave that off by default because it's potentially a gross privacy violation for some sites, gives too much of a hint who anonymous users might be.
If you have a cookie login, but you have high security and an unvalidated IP, then go to reset password, then you'll be told the username is not active and shown some junk HTML.
This is because the reset password script checks the given username using AJAX, and the AJAX notices a cookie login not fulfilled so tries and activates, finds an IP validate is needed, then fails to send the email due to a missing dependency within fast-loading AJAX scripts. This results in non-sense going back to the user and an incorrect 'missing username' perception.
P.S. First time I've ever clicked on a GitHub commit link and that one above gives me a 404. Just tried another commit link from another fixed bug and that one worked, so thought I would mention it (even though it's probably not important). This is what I do ;)