#1814 - Updating addons results in an addon not supported error

By PDStig
Added 3rd Mar 2015, 12:41 AM
6 views

Identifier	#1814
Issue type	Minor issue (breaks specific functionality)
Title	Updating addons results in an addon not supported error
Status	Completed
Handling member	PDStig
Addon	core_addon_management
Description	When trying to update non-bundled addons from Composr (after doing the 9.0.17 update), trying to update addons leaves with an error basically saying the file type "" is not allowed. This error continues even after removing file extension restrictions in security configuration. In order to update the addons, I had to manually do it by downloading the updated addons from Composr and then uploading them through the addon management. I should have taken a screenshot of the error, but I will try to post it once I get the daily digest.
Steps to reproduce	1. Have an old version of something like Activity Feed addon installed. 2. Upgrade to 9.0.17 3. Attempt to update the addons. 4. You get the addon not supported error.
Funded?	No
Commits	a991473

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 3rd Mar 2015, 12:52 AM

By Guest posted 3rd Mar 2015, 12:55 AM

By Guest posted 3rd Mar 2015, 12:56 AM

Screenshots of stack trace uploaded. Most important is Untitled and Untitled2. Untitled shows error message. Untitled2 shows possible cause... where it sends the tmp file generated by addon updater through a file extension check.

By Guest posted 3rd Mar 2015, 1:32 PM

I can also confirm the same issue after updating one of my sites to 9.0.17. Going to adminzone->structure->addons, selecting the 'Import updated addons' link, and then attempting to import those addons results in a stack trace. In my case, the first argument of the check_extension function is showing my domain name 'www.tfo.net' and my error message says "Sorry, but 'net' files can not be uploaded."

By Guest, By Guest, posted 4th Mar 2015, 8:50 AM

I am also getting this error saying "com" and "org" files are not allowed.

By Guest posted 5th Mar 2015, 8:33 AM

Sorry for the bug guys. Our adjusted input filtering was being over-zealous, didn't allow reference to any off-site URLs, while previously this limitation was more focused. It probably affects a few other corners of Composr also. Not an intentional change, but we adjusted our code a lot when reviewing it. Hot-fix coming.

By Guest posted 5th Mar 2015, 8:35 AM

Automated response: Addon installation from compo.sr broken

Addon installation does not work when installing via selecting direct from compo.sr. This is due to the upgraded input-filter being over-zealous with controlling allowed URLs within the system.

#1814 - Updating addons results in an addon not supported error

Rating

Comments

Statistics