#1796 - Upgrade CKEditor kama skin
-
By Chris Graham
- Added
- 8 views
| Identifier | #1796 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Upgrade CKEditor kama skin |
| Status | Completed |
| Tags |
Pseudo-addon: CKEditor (custom) |
| Handling member | Chris Graham |
| Addon | core_rich_media |
| Description | Kama looks dated on hi-dpi screens, as it doesn't support them properly. It probably looks worse on hi-dpi than normal-dpi, as the images have been pre-blown-up fairly badly.
We should update Kama and to Retina ourselves and donate it back. data/ckeditor/skins/kama/icons_hidpi.png |
| Steps to reproduce | |
| Additional information | An alternative plan was to switch to moono:
Switch to moono, as it supports hi-dpi (kama looks dated now). http://ckeditor.com/addon/moono We'll need to update our build-config.js. However, I think it is better we upgrade Kama. I like moono, but by upgrading Kama we give users choice (switching skins isn't too hard) -- not just in the Composr community, but also the wider CKEditor community. It would be nice to give something back. Kama is colourful, as opposed to the mono moono skin. |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Yes, this direction is fine, though I'll want to learn how to switch between skins so that I can compare both, see how they are on the eyes.
http://dev.ckeditor.com/ticket/12932
1) place the skin files in data/ckeditor/skins/
2) edit the WYSIWYG_SETTINGS.tpl template change..
var editor_settings={
to:
var editor_settings={
skin: 'moono',
(i.e. add a line, obviously use the correct skin name)
3) empty the template cache manually if you didn't do the template edit from within Composr (JAVASCRIPT_EDITING.tpl needs decacheing).
The new default theme will be moono.
We have submitted Retina support for Kama upstream:
http://dev.ckeditor.com/ticket/12918
Generally we've worked on improved documentation, including how to switch skins. So the new Kama could be dropped in when upstream releases it.
I don't want us to fork CKEditor to get the improved Kama in immediately, I'd rather do this via a cooperative model.