#1472 - Keep parameters not propagated in IE11
-
By Chris Graham
- Added
- 8 views
| Identifier | #1472 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | Keep parameters not propagated in IE11 |
| Status | Completed |
| Handling member | Chris Graham |
| Version | 9.0.10 |
| Addon | General / Uncategorised |
| Description | If you set keep parameters, they will not propagate across URL clicks, unless IE11 is in compatibility mode.
Technical explanation follows... This is a set of old Composr bugs that did not surface until IE11 was released: 1) get_bot_type function not caching its "quick exit" optimisation result, designed so we quickly identify that known browsers are not bots (a bug, and a very small performance issue) 2) Skipping of keep parameters for bots using the wrong global cache value, relying on bug 1 to work (again, an optimisation - reading straight from cached value, but this time incorrectly treating the lack of cached value as meaning 'not a bot') Plus: 3) IE11 uses Trident instead of MSIE in the user-agent string, and we must now recognise this in our browser detection code. Because IE11 was not slipstreamed as a known non-bot, the correct global variable setting was set, and hence the incorrect value check triggered the code to work a if IE11 was a bot. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
There have been no comments yet