#1065 - Re-test HipHop PHP support
-
By Chris Graham
- Added
- 6 views
| Identifier | #1065 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Re-test HipHop PHP support |
| Status | Completed |
| Tags |
Type: Performance (custom) |
| Handling member | Chris Graham |
| Addon | core |
| Description | Recently the new HHVM support in Facebook's Hip Hop PHP was not working for us - do another round of testing and report bugs, and consider deploying it for testing on our own server. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
A standard Composr front page loads in about 0.12 seconds (when the static cache is not on). The standard forum index is a similar time. With the static cache, it is about 0.04 seconds which is equal to the initiation/latency in HHVM in general.
This is with all the addons installed. If many were uninstalled it would be more like 0.08. Removing the breadcrumbs addon shaves about 0.02s off itself and removing others will reduce the number of hooks scanned etc.
We have implemented support for 'Hack', which is HHVM's type-strict mode. We convert from our phpdoc comments on-the-fly, creating type-strict HHVM Hack files. This is disabled by default though, needing a code edit in sources/global.php (because it crashes harshly if we make a small mistake). This works well and improves our code quality, but there wasn't any noticeable speed improvement. This is probably because the VM already is detecting types automatically.
HHVM is much more usable than the old HipHop compiler was. You no longer need to compile, and Facebook have made things a whole lot more stable over time. I opened a few bug reports, but they could all be worked around easily.
When testing performance...
$SITE_INFO['safe_mode']='1';
$SITE_INFO['dev_mode']='0';
This makes it more release-like. If safe-mode is off, inefficient execution happens (due to the override systems code rewriting), and also all the non-bundled addons in git will run. If dev-mode is on there's a bit of inefficiency.
APC seems to slow things down a bit. This will likely improve when we implement the self-learning cache and hence don't need to read the whole config table out of APC each time.