View Issue Details

IDProjectCategoryView StatusLast Update
5820Composrstatspublic2024-08-01 00:27
ReporterPDStig Assigned ToPDStig  
PriorityhighSeveritytrivial 
Status resolvedResolutionfixed 
Product Version11.beta1 
Summary5820: No validation for id parameter in stats module
DescriptionThere is no validation for what is being passed in the ID parameter for admin_stats type category. This triggers either an INTERNAL ERROR or an undefined array key on line 343 if the ID is invalid.
TagsRoadmap: v11
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

admin

2024-07-30 12:39

administrator   ~9000

Automated message: This issue was created using the Report Issue Wizard on the Composr homesite.

admin

2024-08-01 00:27

administrator   ~9046

Automated response: No validation for id parameter in stats module

If an invalid category ID was provided, we would try to access an array offset which does not exist to get the screen title.

This patch throws a missing resource error if the provided category ID does not exist.

admin

2024-08-01 00:27

administrator   ~9047

Fixed in Git commit 31a833c339 (https://gitlab.com/composr-foundation/composr/commit/31a833c339 - link will become active once code pushed to GitLab)

admin

2024-08-01 00:28

administrator   ~9048

A hotfix (a TAR of files to upload) has been uploaded to this issue. Only apply this hotfix if you absolutely need it and cannot wait until the next release of Composr (releases are more reliable and strictly tested). As of Composr version 11, the recommended way to apply a hotfix is by following the same steps as an upgrade (https://baseurl/upgrader.php, use the hotfix on the step “Transfer across new/updated files”). The upgrader will automatically skip files belonging to addons you do not have installed or that are newer on disk than in the hotfix. Otherwise, you can manually extract and replace these files (do not replace if your on-disk file is newer than the one in the hotfix). Always take backups of your site or at least files you are replacing before applying a hotfix. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Issue History

Date Modified Username Field Change
2024-07-30 12:40 PDStig Tag Attached: Roadmap: v11