View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 5783 | Composr alpha bug reports | galleries | public | 2024-06-04 16:47 | 2024-10-23 18:19 |
| Reporter | PDStig | Assigned To | PDStig | ||
| Priority | high | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 5783: watermarking is broken | ||||
| Description | Watermarking simply does nothing even if a watermark is assigned to a gallery and was ticked when adding new images. | ||||
| Steps To Reproduce | Only tested with mass-add to gallery so far with watermark added directly on the child gallery (not tested with parent galleries) | ||||
| Additional Information | GD installed so I expected this to work. | ||||
| Tags | Roadmap: v11 | ||||
| Attach Tags | |||||
| Attached Files | |||||
| Sponsorship open | |||||
|
|
Automated message: This issue was created using the Report Issue Wizard on the Composr homesite. |
|
|
Automated response: watermarking is broken Watermarking simply does nothing even if a watermark is assigned to a gallery and was ticked when adding new images. Actually this was part of a larger fundamental issue. Gallery images were not being run through handle_images_cleanup_pipeline unless bulk imported. Therefore, they were not getting watermarked among other things. This hotfix fixes the following issues: * Moves calls for handle_images_cleanup_pipeline into the add_image and edit_image API instead of bulk import via media_wrap. * Fixes find_gallery_watermarks which did not properly navigate the full gallery tree to get all the available watermarks. * Changes behaviour of using a File/Media library image in a gallery; Composr will copy the image into uploads/galleries and apply handle_images_cleanup_pipeline to that (using that as the image and not the actual File/Media library one). This is to prevent modifying the original file in the file/media library. * Removes a duplicate SQL clause in Module_cms_galleries::has_at_least_one_watermark |
|
|
Fixed in Git commit 890cc3ff3a (https://gitlab.com/composr-foundation/composr/commit/890cc3ff3a - link will become active once code pushed to GitLab) |
|
|
A hotfix (a TAR of files to upload) has been uploaded to this issue. Only apply this hotfix if you absolutely need it and cannot wait until the next release of Composr (releases are more reliable and strictly tested). As of Composr version 11, the recommended way to apply a hotfix is by following the same steps as an upgrade (https://baseurl/upgrader.php, use the hotfix on the step “Transfer across new/updated files”). The upgrader will automatically skip files belonging to addons you do not have installed or that are newer on disk than in the hotfix. Otherwise, you can manually extract and replace these files (do not replace if your on-disk file is newer than the one in the hotfix). Always take backups of your site or at least files you are replacing before applying a hotfix. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-07-25 22:30 | Chris Graham | Tag Attached: Roadmap: v11 |
