View Issue Details

IDProjectCategoryView StatusLast Update
5613Composrcore_form_interfacespublic2024-06-07 18:50
ReporterPDStig Assigned ToPDStig  
PrioritynormalSeveritytrivial 
Status resolvedResolutionfixed 
Product Version11.alpha4 
Summary5613: Accessibility labels incorrect for multi fields
DescriptionThe "for" attribute of labels on multi-line fields is wrong. Since these fields are suffixed with _index, this method of doing labels will not work.

We will need to create a new label for every new input that is created. Do this via JavaScript.
TagsNo tags attached.
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

admin

2024-06-07 18:50

administrator   ~8833

Automated response: 5613: Accessibility labels incorrect for multi fields

The "for" attribute of labels on multi-line fields is wrong. Since these fields are suffixed with _index, this method of doing labels will not work.

Actually I did not see this happening anymore, but what should have been happening was a new "accessibility-hidden" label element for each new field. It only existed on the first input but not the new ones. This patch fixes the JS so that a new label is created for each new input.

admin

2024-06-07 18:50

administrator   ~8834

Fixed in Git commit ee16b56aee (https://gitlab.com/composr-foundation/composr/commit/ee16b56aee - link will become active once code pushed to GitLab)

admin

2024-06-07 18:50

administrator   ~8835

A hotfix (a TAR of files to upload) has been uploaded to this issue. Only apply this hotfix if you absolutely need it and cannot wait until the next release of Composr (releases are more reliable and strictly tested). As of Composr version 11, the recommended way to apply a hotfix is by following the same steps as an upgrade (https://baseurl/upgrader.php, use the hotfix on step 5). The upgrader will automatically skip files belonging to addons you do not have installed or that are newer on disk than in the hotfix. Otherwise, you can manually extract and replace these files (do not replace if your on-disk file is newer than the one in the hotfix). Always take backups of your site or at least files you are replacing before applying a hotfix. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Issue History

Date Modified Username Field Change
2024-02-15 19:38 PDStig New Issue
2024-02-15 19:38 PDStig Status Not Assigned => Assigned
2024-02-15 19:38 PDStig Assigned To => user4172