View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
5536Composrcore_themeingpublic2024-01-07 15:432024-07-25 21:11
ReporterMaster Rat Assigned ToPDStig  
PrioritynormalSeverityfeature 
Status resolvedResolutionfixed 
Summary5536: Theme Image Editing menu
DescriptionThere is a very long load time for images being loaded.

I think adding a page loading indicator would be a good idea so the end user isn't clicking while loading images .
Steps To ReproduceGo to edit theme images I noticed the page is loading icons and it does take a moment for it to complete if you have or are dealing with a lot of themes being created this causes the delay. You can't see the page is still loading unless you notice up at the browser bar indicating its still ongoing. Users not aware will be clicking expecting the drop down display of the images under the selected item.
TagsRoadmap: v11
Attach Tags
Attached Files
editthemimages.png (107,459 bytes)   
editthemimages.png (107,459 bytes)   
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

Search Commits
related to 5539 AssignedPDStig Scan for places we could use lazy loading 

Activities

PDStig

2024-01-07 16:32

administrator   ~8162

Last edited: 2024-01-07 16:33

 I'm not sure if I'm understanding fully.

Is it the images themselves (thumbs) taking a while to load on the page... or is it the actual theme image entry boxes taking a while to load / appear in the drop downs?

If the clickable box loads quickly, then I don't think it's a big deal the image / thumb itself takes a while. There's no harm early-clicking something aside from the higher possibility you'd click the wrong thing. But I think the idea of allowing users to interact on a page as soon as possible (a web standard that affects SEO rankings) trumps that caveat.

If the boxes themselves are taking a while to load and therefore you physically cannot click to edit said theme image until it loads, that's definitely a problem.

Master Rat

2024-01-08 13:54

reporter   ~8164

OK when you load up this page it shows what I see above however when you click to view the images its still in process loading the complete page of images to edit. I want to say the page loads correctly but all the images are creating a lag in loading I would say about 30 seconds to 45 seconds before you can even click to view the section of images. Hope this helps clarify.

PDStig

2024-01-08 14:27

administrator   ~8166

Okay, I think I understand. It sounds like there may be an issue with JavaScript; because the images are taking so long to load, some JavaScript is being deferred until after the images load, thus probably why you can't click anything yet. I'll look into it.

PDStig

2024-01-08 17:21

administrator   ~8167

Check https://gitlab.com/composr-foundation/composr/-/commit/7814c91fd787b1d32b7e9154eb79c2710eadca1c

I added lazy loading to the theme images. There's really no reason to load all of the images right away, plus it was delaying the deferred JavaScript by doing so. This should speed things up significantly. Please let me know if it works.

Issue History

Date Modified Username Field Change
2024-01-07 15:43 Master Rat New Issue
2024-01-07 15:43 Master Rat File Added: editthemimages.png
2024-01-07 16:32 PDStig Note Added: 0008162
2024-01-07 16:33 PDStig Note Edited: 0008162
2024-01-08 13:54 Master Rat Note Added: 0008164
2024-01-08 14:26 Guest Note Added: 0008165
2024-01-08 14:27 PDStig Note Added: 0008166
2024-01-08 17:19 PDStig Tag Attached: Roadmap: v11
2024-01-08 17:21 PDStig Assigned To => user4172
2024-01-08 17:21 PDStig Status Not Assigned => Resolved
2024-01-08 17:21 PDStig Resolution open => fixed
2024-01-08 17:21 PDStig Note Added: 0008167
2024-07-25 19:54 Chris Graham Summary V11 Theme Image Editing menu => Theme Image Editing menu
2024-07-25 21:11 Chris Graham Relationship added related to 5539