View Issue Details

IDProjectCategoryView StatusLast Update
5496ComposrGeneral / Uncategorisedpublic2024-11-12 17:25
ReporterPDStig Assigned ToChris Graham  
PrioritynormalSeverityminor 
Status assignedResolutionopen 
Summary5496: _backups unit test is broken
DescriptionThe _backups unit test is broken.

It needs mysql root to create the test database to restore into. When I tried modifying the unit test to put that in the _config.php file (at the end) within the backup exports, this did not work. It still tried to use the other non-root username.

I also tried moving this config file temporarily to the main config file when running the restore iterations, thinking it was using the main config file and not the one in the test folder. But I was wrong; it was trying to use the test folder config, so that did not work either.

This unit test needs careful re-review. For the time being, it's low priority because admins are encouraged to use their web panel for backups instead.
TagsRoadmap: Over the horizon
Attach Tags
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

Chris Graham

2024-07-31 19:12

administrator   ~9023

For reference this test is triple-underscore prefixed, meaning it's not necessarily expected to work.
Sounds like it is making some unneeded or undocumented assumptions though, which should be corrected.

PDStig

2024-07-31 20:41

administrator   ~9027

I believe I changed it to triple-underscore some time after making this issue.

I changed the semantic meaning of underscores.
No = standard test, can run concurrently
Single = Slower test, can run concurrently but only in single-thread
Double = Slower test / messes with settings or could break other tests. Cannot run concurrently. Should be run sparingly.
Triple = Must be run via command line. Cannot run concurrently. Should be run sparingly.

Tests not expected to pass are indicated as such in comments inside the files.

PDStig

2024-11-12 17:25

administrator   ~9564

FYI the above is no longer true...

We now have separate directories... first_tests, cli_tests, async_tests, and sync_tests.

The underscore semantics are as follows:
None = Expected to pass, and should be run on every patch, minor, and major release.
Single underscore = Expected to pass but may need special consideration. Should be run on every minor and major release, but not necessary for patch releases.
Double underscore = Not expected to pass and needs careful review. Should be run on every major release. Not necessary for minor or patch releases.

Add Note

View Status
Note
Upload Files
Maximum size: 32,768 KiB

Attach files by dragging & dropping, selecting or pasting them.
You are not logged in You are not logged in. This means you will not get any e-mail notifications. And if you reply, we will not know for sure you are the original poster of the issue.

Issue History

Date Modified Username Field Change
2023-12-09 19:07 PDStig New Issue
2023-12-09 19:07 PDStig Status Not Assigned => Assigned
2023-12-09 19:07 PDStig Assigned To => Chris Graham
2024-07-31 19:12 Chris Graham Note Added: 0009023
2024-07-31 20:41 PDStig Note Added: 0009027
2024-09-13 03:39 PDStig Tag Attached: Roadmap: Over the horizon
2024-11-12 17:25 PDStig Note Added: 0009564