5379: Top 10 block code not working - Composr CMS feature tracker

ID	Project	Category	View Status	Date Submitted	Last Update

5379	Composr	galleries	public	2023-03-25 16:09	2023-11-20 02:21

Reporter	Adam Edington	Assigned To	Chris Graham
Priority	normal	Severity	trivial
Status	assigned	Resolution	open
Product Version	10.0.43

Summary	5379: Top 10 block code not working
Description	Top 10 block code in POPULAR.tpl seems to be returning recent content rather than ordering by popularity.
Tags	No tags attached.
Attach Tags	(Separate by ",")

Time estimation (hours)
Sponsorship open

Date Added	Member	Amount Sponsored

PDStig 2023-11-12 21:19 administrator ~8035	Is ratings enabled? The block by design uses most recent instead of top 10 when ratings are disabled because without ratings there is no metric for determining "top" galleries.

Adam Edington 2023-11-14 20:09 administrator ~8043 Last edited: 2023-11-14 20:10	Reviews were enabled, which include ratings (might not be the same, kinda weird having 2 different methods of rating potentially available). I recall that regardless of the ratings being enabled or not that all blocks show up on root but the Top 10 code was ordering by latest (which as you've explained is likely intentional). You can leave this one be as I've since deleted the install and can't refer to it.

PDStig 2023-11-18 04:02 administrator ~8054	I think I found the issue. The block is using the wrong parameters. I'll push a hotfix as soon as I can.

PDStig 2023-11-20 02:20 administrator ~8055 Last edited: 2023-11-20 02:21	GALLERY_POPULAR is using the wrong parameter: "mode" when it should be using "sort". However, beyond that, it's still not ordering by rating, and I have no idea why. SQL looks fine to me. (also "top" is not a valid sorting mechanism... it should be "average_rating")

View Status	Private (for security issues or disclosing of private information; if you submit as a guest, you will not be able to see your submission)
Note
Upload Files Maximum size: 32,768 KiB	Attach files by dragging & dropping, selecting or pasting them.
You are not logged in	You are not logged in. This means you will not get any e-mail notifications. And if you reply, we will not know for sure you are the original poster of the issue.

Date Modified	Username	Field	Change
2023-03-25 16:09	Adam Edington	New Issue
2023-11-12 21:19	PDStig	Note Added: 0008035
2023-11-14 20:09	Adam Edington	Note Added: 0008043
2023-11-14 20:10	Adam Edington	Note Edited: 0008043
2023-11-18 04:02	PDStig	Note Added: 0008054
2023-11-20 02:19	PDStig	Assigned To	=> Chris Graham
2023-11-20 02:19	PDStig	Status	Not Assigned => Assigned
2023-11-20 02:20	PDStig	Note Added: 0008055
2023-11-20 02:21	PDStig	Note Edited: 0008055