View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
5189Composr alpha bug reportsGeneral / Uncategorisedpublic2022-12-21 18:002022-12-23 01:38
ReporterPDStig Assigned ToChris Graham  
PrioritynormalSeverityminor 
Status resolvedResolutionfixed 
Summary5189: jumping comcode tag does not work on pages (but does in previews)
DescriptionThe jumping comcode tag does not work on the actual comcode page (but it does in previews). Seems the "parts" template parameter is not getting added, and I don't understand why. Everything checks out in comcode_renderer.php lines 1216-1231 ($_parts has the expected values in them).
TagsNo tags attached.
Attach Tags
Attached Files
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

Chris Graham

2022-12-22 01:05

administrator   ~7830

I can't reproduce this.

PDStig

2022-12-22 16:32

administrator   ~7831

Here's the div. "parts" is supposed to be an array parameter in the template (in this case, with 3 items), but it doesn't exist, causing a console error. It exists in the preview.
Screenshot_20221222_113144.png (255,259 bytes)   
Screenshot_20221222_113144.png (255,259 bytes)   

Chris Graham

2022-12-23 01:38

administrator   ~7833

Fixed in https://gitlab.com/composr-foundation/composr/-/commit/6d7b7347778059991377d3053cf6bec2af4751ed
Very difficult bug. When a template was first compiled, Composr would detect various parameters were not used and not bind those parameters in the do_template call. However, parameters referenced in the PARAMS_JSON were not considered used.

Probably was a big bug happening in many places, surprised we only just found it.

Issue History

Date Modified Username Field Change
2022-12-21 18:00 PDStig New Issue
2022-12-21 18:00 PDStig Status Not Assigned => Assigned
2022-12-21 18:00 PDStig Assigned To => Chris Graham
2022-12-22 01:05 Chris Graham Note Added: 0007830
2022-12-22 16:32 PDStig File Added: Screenshot_20221222_113144.png
2022-12-22 16:32 PDStig Note Added: 0007831
2022-12-23 01:38 Chris Graham Note Added: 0007833
2022-12-23 01:38 Chris Graham Status Assigned => Resolved
2022-12-23 01:38 Chris Graham Resolution open => fixed
2023-02-26 18:29 Chris Graham Category General => General / Uncategorised