View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 4891 | Composr | core_database_drivers | public | 2022-08-16 17:50 | 2022-08-30 01:09 |
| Reporter | PDStig | Assigned To | Chris Graham | ||
| Priority | normal | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 4891: Properly abstract ALTER queries | ||||
| Description | There is currently no proper abstraction for ALTER database queries for database drivers other than mysqli. For example, MySQL / MariaDB uses CHANGE COLUMN, but Oracle and PostgreSQL use RENAME COLUMN. MSSQL uses something entirely different. https://www.techonthenet.com/sql/tables/alter_table.php | ||||
| Tags | Roadmap: v11 | ||||
| Attach Tags | |||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
Some quick research tells me... Only MySQL 8+ / MariaDB 10.5+ supports the "RENAME COLUMN" syntax. (which is better as the field type does not need respecifying) Altering table column types also varies based on DB. I think most DBs don't support altering column types and renaming at the same time like MySQL does - meaning we'll need to split the operations in our code. I do not know what the ANSI standards are, if there are any for this kind of query. |
|
|
Nice multi-DB overview: https://www.techonthenet.com/sql/tables/alter_table.php |
|
|
I did have a look at the ANSI standard. They do not seem to specify renaming columns, but do specify adding and dropping columns and changing types. The ANSI standard is *horrible* to read, it's all defining a formal grammar and doesn't even show any examples of real SQL. Rant: What's the point of going to the extreme effort to define a standard in formal grammar (and failing to make a spec that is actually readable), when you can't even get any vendor to implement the standard well? (none do) |
|
|
This was a lot of work. Done, with good automated testing. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-08-16 17:50 | PDStig | New Issue | |
| 2022-08-16 17:50 | PDStig | Status | Not Assigned => Assigned |
| 2022-08-16 17:50 | PDStig | Assigned To | => Chris Graham |
| 2022-08-17 19:46 | Chris Graham | Note Added: 0007465 | |
| 2022-08-17 19:47 | Chris Graham | Note Added: 0007466 | |
| 2022-08-18 21:22 | Chris Graham | Tag Attached: Roadmap: v11 | |
| 2022-08-25 00:39 | Chris Graham | Note Added: 0007489 | |
| 2022-08-25 01:59 | Chris Graham | Note Edited: 0007465 | |
| 2022-08-30 01:09 | Chris Graham | Status | Assigned => Resolved |
| 2022-08-30 01:09 | Chris Graham | Resolution | open => fixed |
| 2022-08-30 01:09 | Chris Graham | Note Added: 0007494 |
