View Issue Details

IDProjectCategoryView StatusLast Update
4785Composrquizzespublic2022-01-26 02:23
ReporterAdam Edington Assigned ToChris Graham  
PrioritynormalSeverityfeature 
Status resolvedResolutionfixed 
Product Version10.0.39 
Fixed in Version10.0.40 
Summary4785: Incorrect answer is correct
DescriptionThank you for entering the competition. Your entry has been saved.

Explanation:

    “Performers who are based in Europe?” was answered with: Aephanemer, Blazing War Machine, Cripper, Forged
    However, this is incorrect. Velkhanos are from Spain.

Forged is the wrong answer as they are from Mexico.
Steps To ReproducePerformers who are based in Europe? [MULTIMULTIPLE] [REQUIRED]
Aephanemer [*]
:Aephanemer are from France.
Blazing War Machine [*]
:Blazing War Machine are from France.
Cripper [*]
:Cripper are from Germany.
Velkhanos [*]
:Velkhanos are from Spain.
Forged
:Forged are from Mexico.
Devil Within
:Devil Within are from Japan.
Core of Dying Earth
:Core of Dying Earth are from Russia.
TagsNo tags attached.
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

Chris Graham

2022-01-26 01:46

administrator   ~7297

Ok, this technically isn't a bug, but it's definitely an oversight.

The explanation syntax is to be shown when a particular answer is given, irrespective of whether that answer is correct or not.

This makes no sense for a MULTIMULTIPLE question, because:
a) Multiple answers are given, so it doesn't know what explanation to output
b) No single explanation can provide a full outlining of the users mistake

So, for a MULTIMULTIPLE we will instead show the explanations of all incorrect answers given. And this shall be the documented behavior.

admin

2022-01-26 01:49

administrator   ~7298

Automated response: Explanation syntax makes no sense for MULTIMULTIPLE questions

Because there are multiple answers selected, we can't just give a single hard-coded explanation of why a particular combination of answers are right/wrong. So change the meaning of the syntax for such questions, and document that.

admin

2022-01-26 01:49

administrator   ~7299

Fixed in git commit 3a1544d9e (https://gitlab.com/composr-foundation/composr/commit/3a1544d9e - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Adam Edington

2022-01-26 02:02

administrator   ~7301

Last edited: 2022-01-26 02:04

"For [tt]MULTIMULTIPLE[/tt] the explanation text will be shown for any and all incorrect answers (separated by spaces)."

In this case the explanation text is showing a correct answer which wasn't selected, rather than the wrong answer (Forged) which was, removing the explanation text won't change that? Or will it? I mean from a marking perspective.

Chris Graham

2022-01-26 02:04

administrator   ~7302

The explanation functionality may be a little confusing.
I've made it work as would be expected for MULTIMULTIPLE.

Generally speaking though, it provides an explanation associated with the answer GIVEN, whether correct or not. Not an answer NOT GIVEN.
Imagine a quiz that asks about why the sky is blue. There is an answer "Refraction" with an explanation "Did you know that on different planets the sky may be a different colour due to different refractive indexes of different atmospheres." - and another answer "Reflection" with an explanation "If it was reflection then the planet would be a lot darker.".

Chris Graham

2022-01-26 02:07

administrator   ~7303

" In this case the explanation text is showing a correct answer which wasn't selected, rather than the wrong answer (Forged) which was, removing the explanation text won't change that? Or will it? I mean from a marking perspective."

Don't get bogged down in what you were seeing here, it wasn't good code and there's no point trying to understand what that logic was doing as it was stupid. For MULTIMULTIPLE the new code will provide explanations of every incorrect answer, both ticked ones that should not have been, and unticked ones that should have been.

Adam Edington

2022-01-26 02:13

administrator   ~7304

Yes, Velkhanos was not a GIVEN answer but it was a correct answer. Forged was GIVEN and was incorrect, I would expect it to let me know that Forged was incorrect rather than revealing a correct answer. Regardless of the explanation text, I am just wondering if the marking is correct? Is it just the explanation which is confused?

Adam Edington

2022-01-26 02:16

administrator   ~7305

Ahh okay, I missed your 2nd reply before responding. That makes sense. Thanks :)

Chris Graham

2022-01-26 02:16

administrator   ~7306

I fixed marking in 4792. As I made this hot fix after that one and they both touch the same file, the hotfix here includes that fix.

Adam Edington

2022-01-26 02:23

administrator   ~7307

Thanks again, pretty cool feature I haven't really used much. Nice way to use points and almost everyone likes a good quiz.

Issue History

Date Modified Username Field Change
2022-01-19 21:45 Adam Edington New Issue
2022-01-26 01:46 Chris Graham Note Added: 0007297
2022-01-26 02:02 Adam Edington Note Added: 0007301
2022-01-26 02:04 Adam Edington Note Edited: 0007301
2022-01-26 02:04 Chris Graham Note Added: 0007302
2022-01-26 02:07 Chris Graham Note Added: 0007303
2022-01-26 02:13 Adam Edington Note Added: 0007304
2022-01-26 02:16 Adam Edington Note Added: 0007305
2022-01-26 02:16 Chris Graham Note Added: 0007306
2022-01-26 02:23 Adam Edington Note Added: 0007307