View Issue Details

IDProjectCategoryView StatusLast Update
4739Composrcore_addon_managementpublic2021-12-19 21:17
ReporterChris Graham Assigned ToChris Graham  
PriorityhighSeverityfeature 
Status resolvedResolutionfixed 
Product Version10.0.39 
Fixed in Version10.0.40 
Summary4739: Some basic locking for addon management
DescriptionUsers often have errors caused by parallel web requests happening while addons are being uninstalled.
For example, they may click an addon uninstallation button and then refresh their browser window so it happens twice in parallel, or while running the Setup Wizard also be browsing the Admin Zone in another tab.
These things can cause errors as caches decached by the addon removal can get repopulated with stale data from an overlapping request.

This changes introduces some locking. It's not perfect. There's a maximum lock time of 1 minute to prevent stale lock problems disabling user's sites. It also won't protect the case of another web request starting before the lock and then populating the cache after the addon management web request finishes. That last scenario is less likely though as an addon management web request would be expected to be a much longer running request.
TagsNo tags attached.
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

related to 4734 ClosedChris Graham Deleting certain addons leaves remnants 

Activities

admin

2021-12-19 21:17

administrator   ~7202

Fixed in git commit e310af6d5 (https://gitlab.com/composr-foundation/composr/commit/e310af6d5 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Issue History

Date Modified Username Field Change
2021-12-19 21:17 Chris Graham Relationship added related to 4734