View Issue Details

IDProjectCategoryView StatusLast Update
4726Composrcorepublic2021-12-20 19:43
ReporterChris Graham Assigned ToChris Graham  
PriorityhighSeveritymajor 
Status resolvedResolutionfixed 
Product Version10.0.39 
Fixed in Version10.0.39 
Summary4726: Fix issues on PHP 8.1
DescriptionThere are a number of issues stopping Composr working on PHP 8.1. Mostly relate to no longer auto-converting null to '' or 0, in calls to PHP functions.

This fixes any issues running our test set, and we've done a cursory check of all pages off of the sitemap. There may be other issues found and fixed over time as it is very difficult to find all these issues due to PHP's dynamic nature.

Additionally PHP 8.1 deprecates strtotime, which we use heavily. For now (and mostly already) we are just suppressing any errors coming out of this function. We will have to remove our usage in a future major version, to support PHP 9 when that comes.
TagsNo tags attached.
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

admin

2021-12-08 01:33

administrator   ~7178

Fixed in git commit 8d7a3f0ca (https://gitlab.com/composr-foundation/composr/commit/8d7a3f0ca - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).
hotfix-4726, 2021-12-08 1am.tar (Attachment missing)

Chris Graham

2021-12-19 17:45

administrator   ~7198

^ Fixed in 4738

Adam Edington

2021-12-20 00:53

administrator   ~7205

Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in \sources\database.php on line 161

Chris Graham

2021-12-20 03:47

administrator   ~7207

^ Fixed in 4740

Issue History

Date Modified Username Field Change
2021-12-19 17:45 Chris Graham Note Added: 0007198
2021-12-20 00:53 Adam Edington Note Added: 0007205
2021-12-20 03:47 Chris Graham Note Added: 0007207