View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 4554 | Composr | core_rich_media | public | 2021-01-18 22:58 | 2022-08-15 15:47 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 4554: Anchor references to jump inside tabs | ||||
| Description | It would be nice to have a standard way to open a specific tab, by default with no effort. Here is a diff I made for it in v10... diff --git a/themes/default/templates/COMCODE_TAB_HEAD.tpl b/themes/default/templates/COMCODE_TAB_HEAD.tpl index a1fbc69b..b01ce074 100644 --- a/themes/default/templates/COMCODE_TAB_HEAD.tpl +++ b/themes/default/templates/COMCODE_TAB_HEAD.tpl @@ -1 +1 @@ -<a aria-controls="g_{$GET|*,tab_sets}_{TITLE|*}" role="tab" href="#" id="t_{$GET|*,tab_sets}_{TITLE|*}" class="tab{+START,IF,{FIRST}} tab_active tab_first{+END}{+START,IF,{LAST}} tab_last{+END}" onclick="select_tab('g','{$GET|*,tab_sets}_{TITLE|*}'); return false;"><span>{TITLE*}</span></a> +<a id="{$GET|*,tab_sets}_{TITLE|*}__jump"></a><a aria-controls="g_{$GET|*,tab_sets}_{TITLE|*}" role="tab" href="#" id="t_{$GET|*,tab_sets}_{TITLE|*}" class="tab{+START,IF,{FIRST}} tab_active tab_first{+END}{+START,IF,{LAST}} tab_last{+END}" onclick="select_tab('g','{$GET|*,tab_sets}_{TITLE|*}'); return false;"><span>{TITLE*}</span></a> However, this could be cleaner. We should review the automatic tab navigation code, which was mainly created for member profile tabs. Ideally it might be possible with something shorter than the "<something>__jump" anchor here, probably just "<something>". It should also be documented. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| Time estimation (hours) | 1 | ||||
| Sponsorship open | |||||
|
|
Implemented for v11. Not documented as it is obvious it is happening, as it is universal across almost every existing tabset. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-01-18 22:58 | Chris Graham | New Issue | |
| 2021-03-15 18:26 | Chris Graham | Tag Attached: Roadmap: v12 | |
| 2021-07-23 00:48 | Chris Graham | Assigned To | => Chris Graham |
| 2021-07-23 00:48 | Chris Graham | Status | Not Assigned => Resolved |
| 2021-07-23 00:48 | Chris Graham | Resolution | open => fixed |
| 2021-07-23 00:48 | Chris Graham | Note Added: 0007108 | |
| 2022-08-15 15:47 | Chris Graham | Tag Detached: Roadmap: v12 |
