View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 3243 | Composr | core | public | 2017-04-23 18:50 | 2017-07-09 00:36 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 3243: Eliminate cms_srv function | ||||
| Description | We now have a function 'fixup_bad_php_env_vars' which is doing complicated pre-cleanup of PHP $_SERVER settings which are often not working correctly. cms_srv serves a similar function. It would be simpler to just let developers use $_SERVER directly, knowing we've cleaned it up fully so its reliable. For this change: Implement new get_local_hostname() function, instead of cms_srv('HTTP_HOST'). This takes some of the old logic from cms_srv that isn't cleanup related. In fixup_bad_php_env_vars copy from LOCAL_ADDR to SERVER_ADDR if missing. In fixup_bad_php_env_vars copy from $_ENV to $_SERVER if missing, then simplify remaining logic of function to only use $_SERVER. Change all remaining cms_srv calls to use $_SERVER directly. Removing cms_srv function. | ||||
| Tags | Risk: Core rearchitecting | ||||
| Attach Tags | |||||
| Time estimation (hours) | 1 | ||||
| Sponsorship open | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-04-23 18:50 | Chris Graham | New Issue | |
| 2017-05-01 16:06 | Chris Graham | Tag Attached: Risk: Core rearchitecting | |
| 2017-07-09 00:36 | Chris Graham | Status | Not Assigned => Resolved |
| 2017-07-09 00:36 | Chris Graham | Resolution | open => fixed |
| 2017-07-09 00:36 | Chris Graham | Assigned To | => Chris Graham |
