View Issue Details

IDProjectCategoryView StatusLast Update
2919Composrbackuppublic2016-11-09 18:48
ReporterPDStig Assigned ToChris Graham  
PrioritynormalSeveritymajor 
Status resolvedResolutionfixed 
Summary2919: Backups fail on readme.txt
DescriptionComposr's backup system (once again) fails on readme.txt; tries to archive it twice, resulting in failure.
Additional InformationComposr 10 RC 20 with task queue enabled
TagsNo tags attached.
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

PDStig

2016-11-02 10:35

administrator   ~4511

Also in backup log:

[02-Nov-2016 03:40:07 UTC] PHP Notice: Array to string conversion in sources/failure.php on line 387 @ /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php
[02-Nov-2016 03:40:07 UTC] Composr: PHP NOTICE [8] Array to string conversion in sources/failure.php on line 387 (version: 10 RC20, PHP version: 7.0.12, URL: /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php) @ /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php

Chris Graham

2016-11-03 19:58

administrator   ~4513

Workaround is to delete readme.txt from disk. Issue is it adds it dynamically, then it's on disk too.

I can't track those error messages but it's basically a PHP bug that misdirects errors into the wrong file after script execution ends, with the line numbers of where the stack trace starts rather than where the error starts. It could be anything.

PDStig

2016-11-03 21:04

administrator   ~4516

Now I get:

Your action was successful.
[03-Nov-2016 21:05:33 UTC] PHP Fatal error: Uncaught Error: Cannot use object of type Tempcode as array in /var/www/vhosts/lovinity.org/httpdocs/sources/tasks.php:135
Stack trace:
#0 /var/www/vhosts/lovinity.org/httpdocs/sources/hooks/systems/cron/tasks.php(45): execute_task_background(Array)
#1 /var/www/vhosts/lovinity.org/httpdocs/sources/misc_scripts.php(309): Hook_cron_tasks->run()
2 /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php(53): cron_bridge_script('/var/www/vhosts...')
3 {main}
  thrown in /var/www/vhosts/lovinity.org/httpdocs/sources/tasks.php on line 135
[03-Nov-2016 21:05:33 UTC] PHP Error: Uncaught Error: Cannot use object of type Tempcode as array in sources/tasks.php:135
Stack trace:
#0 sources/hooks/systems/cron/tasks.php(45): execute_task_background(Array)
#1 sources/misc_scripts.php(309): Hook_cron_tasks->run()
2 data/cron_bridge.php(53): cron_bridge_script('/var/www/vhosts...')
3 {main}
  thrown in sources/tasks.php on line 135 @ /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php

The backup completed though.

Chris Graham

2016-11-04 17:37

administrator   ~4518

Fixed also.

Be aware the backup system isn't restoring properly, this was a recent issue - the next RC will correct multiple issues with backups.

PDStig

2016-11-04 17:43

administrator   ~4519

Alright sounds good. Thanks Chris for the heads up.

bobmiers

2016-11-04 21:22

reporter   ~4521

Chris: Any idea when the next RC will be issued.

BTW I had the same problem as Patrick had but with an additional duplicate file. After renaming the readme.txt file, and rerunning the restore.php. The restore_data file popped up as a duplicate as well.

Chris Graham

2016-11-04 21:24

administrator   ~4522

Right, yes - I've made it so when generating a backup duplicates like that are ignored.

Chris Graham

2016-11-04 21:24

administrator   ~4523

New RC possibly tomorrow.

bobmiers

2016-11-05 09:21

reporter   ~4524

Chris: Installed RC21, created a full backup and then attempted a restore. After a couple of minutes I got an error screen which I captured; ZIPed as RC21backup-restore_errors.zip & attached to this note FYI.

Please note that earlier I indicated that I think my database is corrupted.

When I went back to my site as admin, I get a series of errors--which I also captured, unless you need that capture I'll refrain from uploading. When I went to my site as guest I have no formatting at all.

At this point in time I think the prudent thing is to start from a clean install--I don't really have all that much to redo. Your suggestions please!

I have not attempted to use an older restore_data.php yet.

Chris Graham

2016-11-09 18:48

administrator   ~4530

This is fixed in this file:

https://raw.githubusercontent.com/ocproducts/composr/master/sources/database_action.php

It was an error on sites without content translation enabled, which is the majority of sites, but not the test environment I was using previously.

Issue History

Date Modified Username Field Change
2016-11-02 10:31 PDStig New Issue
2016-11-02 10:35 PDStig Note Added: 0004511
2016-11-03 19:58 Chris Graham Note Added: 0004513
2016-11-03 21:04 PDStig Note Added: 0004516
2016-11-04 17:37 Chris Graham Note Added: 0004518
2016-11-04 17:43 PDStig Note Added: 0004519
2016-11-04 21:22 bobmiers Note Added: 0004521
2016-11-04 21:24 Chris Graham Note Added: 0004522
2016-11-04 21:24 Chris Graham Note Added: 0004523
2016-11-05 09:21 bobmiers Note Added: 0004524
2016-11-05 15:33 bobmiers File Added: RC21backup-restore_errors.zip
2016-11-09 18:48 Chris Graham Note Added: 0004530
2016-11-09 18:48 Chris Graham Status Not Assigned => Resolved
2016-11-09 18:48 Chris Graham Resolution open => fixed
2016-11-09 18:48 Chris Graham Assigned To => Chris Graham