View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 2299 | Composr | core | public | 2016-03-15 13:49 | 2016-07-17 18:56 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 2299: Refactor some use of global variables | ||||
| Description | Some people will hate that we use global variables, but I honestly think this is better than passing context parameters through a massive call tree, or implementing complex singleton/manager/static-class kinds of system. Globals are simpler (easier to understand, better performance, less code overhead), especially for cases where we're just setting simple state toggles. However, we should not let this make our code tidy. We already insist on using phpdoc against every global used in more than a small number of places. We still have a case where we toggle some state variables temporarily on then off. It's an ugly code pattern... $dbs_bak = $GLOBALS['NO_DB_SCOPE_CHECK']; $GLOBALS['NO_DB_SCOPE_CHECK'] = true; ... $GLOBALS['NO_DB_SCOPE_CHECK'] = $dbs_bak; This would be better as... push_db_scope_check(false); ... pop_db_scope_check(); I've identified (via careful code grepping) these globals we should handle via functions: - NO_DB_SCOPE_CHECK - SUPPRESS_ERROR_DEATH - LAX_COMCODE - NO_LINK_TITLES - NO_QUERY_LIMIT NO_QUERY_LIMIT should reset the query limit to what it was when popped. | ||||
| Tags | Risk: Core rearchitecting | ||||
| Attach Tags | |||||
| Time estimation (hours) | 2 | ||||
| Sponsorship open | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-03-15 13:49 | Chris Graham | New Issue | |
| 2016-03-15 13:49 | Chris Graham | Tag Attached: Core rearchitecting | |
| 2016-06-08 00:15 | Chris Graham | Tag Renamed | Core rearchitecting => Risk: Core rearchitecting |
| 2016-07-17 18:56 | Chris Graham | Status | Not Assigned => Resolved |
| 2016-07-17 18:56 | Chris Graham | Resolution | open => fixed |
| 2016-07-17 18:56 | Chris Graham | Assigned To | => Chris Graham |
