View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 220 | Composr | core_themeing | public | 2010-11-22 00:41 | 2010-12-30 23:10 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 220: Fixup screen previews | ||||
| Description | There's additional tidying-up I'd like doing to the screen previews, to make things a bit more user-friendly. [codebox] Merging (some may already be included in the target, in which case just delete the source and map it's templates to the target): --------- tpl_preview__administrative__validate_error_screen -> tpl_preview__administrative__validate tpl_preview__lookup_ip_list_group -> tpl_preview__lookup_screen tpl_preview__next_browser_browse_next -> tpl_preview__next_browser_screen tpl_preview__cns_edit_forum_screen_forum -> tpl_preview__cns_edit_forum_screen tpl_preview__cns_view_group -> tpl_preview__cns_view_group_screen tpl_preview__form_screen_input_hidden -> tpl_preview__form_screen_2 tpl_preview__download_box -> download_category_screen tpl_preview__comcode_section -> tpl_preview__comcode_section_controller tpl_preview__attachment -> tpl_preview__attachments tpl_preview__attachments_browser_attachment -> tpl_preview__attachments_browser tpl_preview__author_screen_potential_action_entry -> tpl_preview__author_screen tpl_preview__block_side_news_categories_category -> tpl_preview__block_side_news_categories tpl_preview__block_side_root_galleries_line -> tpl_preview__block_side_root_galleries tpl_preview__block_side_root_galleries_line_container -> tpl_preview__block_side_root_galleries tpl_preview__block_side_root_galleries_line_depth -> tpl_preview__block_side_root_galleries tpl_preview__catalogue_entry_add_to_cart -> tpl_preview__catalogue_category_screen__products tpl_preview__cart_logo -> tpl_preview__catalogue_product_entry tpl_preview__cedi_post -> tpl_preview__cedi_page_screen tpl_preview__comcode_critical_parse_error -> tpl_preview__comcode_mistake_screen tpl_preview__comcode_editor -> tpl_preview__posting_form tpl_preview__comcode_editor_button -> tpl_preview__posting_form tpl_preview__comcode_editor_micro_button -> tpl_preview__posting_form tpl_preview__comcode_message -> tpl_preview__posting_form tpl_preview__comcode_jumping_part -> tpl_preview__comcode_jumping (and I want to see it working!) tpl_preview__comcode_real_table_cell -> tpl_preview_comcode_table_screens tpl_preview__comcode_real_table_row_end -> tpl_preview_comcode_table_screens tpl_preview__comcode_real_table_start -> tpl_preview_comcode_table_screens tpl_preview__comcode_real_table_start_summary -> tpl_preview_comcode_table_screens tpl_preview__comments_default_text -> tpl_preview__comments_wrapper tpl_preview__emoticon_click_code -> tpl_preview__comments + core_feedback_features + tpl_preview__support_ticket_screen + tpl_preview__block_main_contact_simple + tpl_preview__block_main_contact_us + tpl_preview__cns_topic_wrap (all should have emoticons) tpl_preview__search_for_search_domain_option_type_text -> tpl_preview__search_form_screen tpl_preview__search_for_search_domain_option_type_tick -> tpl_preview__search_form_screen tpl_preview__template_edit_screen_dropdown -> tpl_preview__template_edit_screen tpl_preview__view_space_field -> tpl_preview__view_space + tpl_preview__view_space_screen tpl_preview__administrative__installer_input_line -> tpl_preview__administrative__installer_step_4 tpl_preview__administrative__installer_input_password -> tpl_preview__administrative__installer_step_4 tpl_preview__administrative__installer_input_tick -> tpl_preview__administrative__installer_step_4 tpl_preview__news_brief -> tpl_preview__news_archive_screen tpl_preview__rss_entry_comments -> tpl_preview__rss_wrapper tpl_preview__results_table_cart_field -> tpl_preview__results_cart_table tpl_preview__results_products_table -> tpl_preview__results_cart_table (I think, not 100% sure) tpl_preview__splurgh -> tpl_preview__splurgh_screen tpl_preview__cns_posting_screen_post -> tpl_preview__cns_posting_screen_posts tpl_preview__cns_user_member -> tpl_preview__cns_topic_wrap tpl_preview__cns_topic_post_custom_field -> tpl_preview__cns_topic_wrap tpl_preview__cns_topic_post_last_edited -> tpl_preview__cns_topic_wrap tpl_preview__block_side_zone_jump --> tpl_preview__zone_choose tpl_preview__block_side_news_summary -> block_side_news tpl_preview__news_piece_summary -> block_main_news tpl_preview__administrative__template_tree_node -> tpl_preview__administrative__template_tree tpl_preview__administrative__template_edit_link -> tpl_preview__administrative__template_tree tpl_preview__administrative__template_list -> tpl_preview__administrative__template_list_screen tpl_preview__administrative__template_list_entry -> tpl_preview__administrative__template_list_screen tpl_preview__form_standard_end -> tpl_preview__form_screen_2 tpl_preview__block_main_banner_wave_bwrap -> tpl_preview__block_main_banner_wave tpl_preview__gallery_nav -> tpl_preview__gallery_entry_screen tpl_preview__gallery_subgallery -> tpl_preview__gallery_regular_mode_screen tpl_preview__gallery_video -> tpl_preview__gallery_regular_mode_screen tpl_preview__gallery_entry_wrap -> tpl_preview__gallery_regular_mode_screen tpl_preview__cns_forum_topic_wrapper -> tpl_preview__cns_forum Misc identified errors: ------------------------ http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=CATALOGUE_DEFAULT_ENTRY_FIELD.tpl&hook=catalogues&function=tpl_preview__catalogue_entry_screen__default&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=CATALOGUE_links_CATEGORY_SCREEN.tpl&hook=catalogues&function=tpl_preview__catalogue_category_screen__links&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=CATALOGUE_products_CATEGORY_SCREEN.tpl&hook=shopping&function=tpl_preview__catalogue_product_category_screen&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 Completely unrealistic. Probably needs splitting into several screens, one for tabs, one for field-maps, etc. When this is done nicely, many other nasty previews can be removed and the templates linked into this: - tpl_preview__catalogue_entry_screen__links - tpl_preview__catalogue_product_entry_field - tpl_preview__catalogue_product_line - tpl_preview__catalogue_product_line_wrap - tpl_preview__catalogue_tpl_line_wrap__default http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=CEDI_POST_SCREEN.tpl&hook=cedi&function=tpl_preview__cedi_post_screen&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 Complete nonsense. Lots of random templates seem to be on this. http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=COMCODE_BIG_TABS_CONTROLLER.tpl&hook=core_rich_media&function=tpl_preview__comcode_big_tabs&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 Javascript not working nicely http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=COMCODE_TAB_BODY.tpl&hook=core_rich_media&function=tpl_preview__comcode_tab_body&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 Messy, want to see nice tabs http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=TRACKBACK_XML_LISTING.tpl&hook=core_feedback_features&function=tpl_preview__trackback_xml_listing&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 Muddled - should be multiple screens http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=BLOCK_MAIN_BANNER_WAVE.tpl&hook=banners&function=tpl_preview__block_main_banner_wave&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 Useless. Need to see banners in here. http://localhost/svn/code/4.2.x/adminzone/index.php?page=admin_themes&type=view&id=CNS_AUTO_TIME_ZONE_ENTRY.tpl&hook=core_cns&function=tpl_preview__cns_auto_time_zone_entry&keep_theme=default&keep_has_js=1&keep_devtest=1&keep_session=9919683&keep_cache=1&keep_wide_high=1 I want to see an actual list. The following screen previews should be administrative -------------------------------------------------------------- zone_editor_screen tempcode_test handle_conflict_resolution validate_check_screen unvalidated_screen translate_screen translate_language_criticise_screen translate_screen_content_screen trackback_delete_screen theme_manage_screen theme_image_preview theme_image_manage_screen theme_edit_css_screen template_manage_screen template_edit_screen_dropdown template_edit_screen table_table_action_translate stats_screen stats_screen_iscreen stats_screen_overview site_tree_editor_screen security_screen security_alert_screen revision_restore show_revision_history redirecte_table_screen permission_s_permissions_screen permission_screen_permissions_screen permission_keys_permissions_screen permissions_tree_editor_screen cns_ldap_sync_screen cns_history_screen cns_edit_forum_screen_forum cns_edit_forum_screen cns_delurk_confirm cns_cpf_stats_screen Commandr_main_screen Commandr_main news_wordpress_import_screen newsletter_subscribers_screen newsletter_confirm_wrap module_screen messaging_message_screen menu_editor_screen lookup_screen lookup_ip_list_group iotd_admin_choose_screen_iotd iotd_admin_choose_screen gallery_import_screen flagrant_manage_screen errorlog_screen ecom_transaction_logs_screen ecom_transaction_logs_manual_trigger ecom_outstanding_invoices_screen ecom_cash_flow_screen config_category_screen chat_moderate_screen cedi_manage_tree_screen banner_added_screen backup_launch_screen addon_uninstall_confirm_screen addon_screen addon_multi_confirm_screen addon_install_confirm_screen addon_export_screen action_logs_screen xml_storage_screen xml_storage_import_results_screen xml_storage_export_results_screen wordfilter_screen Other ------ In core_menus.php all the 'THE_LEVEL' and 'POSITION' values should be set correctly. There are preview functions that are not used (e.g. rss_view_summery). Write some code to identify them then remove them. Make sure the files are neat, e.g. tabbing (spaces not tabs). I'm sure an automated tool can do this. Run the Code Quality checker I want a unit test that validates all the previews. I have some commented out code that is close to doing this, but it should be moved to a proper unit test [/codebox] | ||||
| Tags | ocProducts priority | ||||
| Attach Tags | |||||
| Time estimation (hours) | 5 | ||||
| Sponsorship open | |||||
