View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 1952 | Composr | calendar | public | 2015-06-05 14:18 | 2015-07-29 01:37 |
| Reporter | PDStig | Assigned To | Guest | ||
| Priority | normal | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 1952: Event details page displays wrong date on events that occur 12am or later GMT | ||||
| Description | When clicking an event to view its details, the details page will display the wrong date if the event occurs 12am or later GMT. All events on my website are set to GMT-4 hours, so any events that start 8pm or later ET will display a date that is one day sooner than the actual date they occur. | ||||
| Steps To Reproduce | 1. Create an event in the GMT-4 time zone and set the start time to occur 8pm or later. 2. Check the event details page for that event. 3. The event details will say the event starts one day sooner than the date you actually set it for. So say if you set it for Thursday May 7, it will say the event is on Wednesday May 6. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| Attached Files | |||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
Is it correct to assume that you are viewing in the GMT-4 timezone? Is "Do timezone conversions" enabled for the event? No recurrence settings set, correct? |
|
|
This is in 9.0.19, without any calendar hotfixes applied after the upgrade happened? (as if there were it would be an old file, as I don't think we've made one recently) To check, go to integrity checker in /upgrader.php and make sure it doesn't report sources/calendar.php as corrupt/outdated. |
|
|
All that said, I can actually reproduce it. You need to go to the calendar, then to the event, not direct to the event. Answering the above will just help me double check things, but I don't strictly need those answers. Sorry it took ages to get to this one. |
|
|
GMT-4 is correct Do timezone conversions is off These events do have recurrence (usually weekly). sources/calendar.php does not show up in the file integrity check. |
|
|
Automated response: Calendar timezone issue for evening events in negative timezone shifts This fixes evening events in negative timezones (e.g. USA) so that links from the calendar don't then list the date in the wrong day. As the calendar code in Composr is extremely complex this has been fixed by carefully adding a test case to our unit tests, and then ensuring all continue to pass. |
|
|
Fixed in git commit 58e029d (https://github.com/chrisgraham/Composr/commit/58e029d - link will become active once code pushed to github) A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). |
