View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 1951 | Composr alpha bug reports | General / Uncategorised | public | 2015-06-05 01:11 | 2015-06-09 14:40 |
| Reporter | Jason Verhagen | Assigned To | Chris Graham | ||
| Priority | normal | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 1951: Icons missing for some uninstalled addons in Adminzone>Structure>Addons | ||||
| Description | For uninstalled addons that have a custom icon file and the icon file is defined in the addon_registry hook get_default_icon() method, the icon won't display in the Admin Zone Addons page because the icon file was uninstalled when the addon was uninstalled. | ||||
| Additional Information | There were at least a couple of ways to attack this bug. I chose to make an edit to the find_addon_icon() function in sources\addons.php where it returns the URL based on what is returned from the addon_registry hook. I changed this: if (($ob !== null) && (method_exists($ob, 'get_default_icon'))) { return get_base_url() . '/' . str_replace('%2F', '/', urlencode($ob->get_default_icon())); } to this: if (($ob !== null) && (method_exists($ob, 'get_default_icon'))) { $file = $ob->get_default_icon(); if (file_exists(get_file_base() . '/' . $file)) { return get_base_url() . '/' . str_replace('%2F', '/', urlencode($ob->get_default_icon())); } else { require_code('mime_types'); $file = $ob->get_default_icon(); $image_data = tar_get_file($tar_file, $file); if ($image_data === null) { continue; } return 'data:' . get_mime_type(get_file_extension($file), true) . ';base64,' . base64_encode($image_data['data']); } } } If the addon_registry hook returns a file path of an existing icon file, it will use that icon file. If the addon_registry hook returns a file path that doesn't exist, it will use that path to try to get the file icon out of the addon .tar archive. If the icon file does not exist on disk or in the .tar archive, it should fall through to the end and use the icons/48x48/menu/_generic_admin/component icon. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| Sponsorship open | |||||
|
|
I will commit this to github. Chris, I'm not sure how many of my bug fix commits will be proper fixes for bugs. Meaning, you may have a better or more proper way to code the bug fixes. I figured if any of my commits need to be reverted, having an open ticket here will give you a way to revert a commit and come back to properly fix the bug later. If you prefer an alternate way of handling this, let me know. |
|
|
Your help is much appreciated Jason. When I'm free again I'll do a review of your commits and make changes if required. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
