View Issue Details

IDProjectCategoryView StatusLast Update
1827Composrcalendarpublic2015-03-25 19:00
ReporterPDStig Assigned ToGuest  
PrioritynormalSeverity@40@ 
Status resolvedResolutionfixed 
Summary1827: Calendar events with an advanced recurrence pattern do not display properly after DST changes
DescriptionCalendar events that have an advanced recurrence (using the recurrence pattern of 1 and 0 option) do not display correctly in the calendar after a shift from standard to daylight savings time.
Steps To Reproduce1. Create an event in the standard time.
2. Give it a recurrence pattern.
3. Daylight Savings time.
4. Check the calendar. Sometimes it will display when it shouldn't (when using # days filter) and sometimes it will display on the wrong days.
Additional InformationIn the screenshot, the circled "Democracy Now" event has a start in November of 2014 (when Standard Time was in effect). The event is supposed to occur Monday-Friday. What you see is a block that shows Calendar events for 3 days. March 15th is a Sunday, and Democracy Now does not occur on a Sunday. In addition, Sunday is in the 4th day range, and I have the limit set to 3 days. There are other events on Sunday as well, but they correctly do not render yet as it is not time.
TagsNo tags attached.
Attach Tags
Attached Files
Untitled.jpg (264,041 bytes)
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

Chris Graham

2015-03-13 13:03

administrator   ~2630

Automated response: DST shift calculation for recurring events

There is a bug in the DST shift calculations regarding events that can cause day shifting inadvertently.

Chris Graham

2015-03-13 13:03

administrator   ~2631

Fixed in git commit aac8f23 (https://github.com/chrisgraham/Composr/commit/aac8f23 - link will become active once code pushed to github)

A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Chris Graham

2015-03-13 13:06

administrator   ~2632

Last edited: 2015-03-13 13:07

Ok, trying to fix this blew my mind, but I'm confident I finally got the correct fix.

It's really confusing because there are MULTIPLE DST shifts. So for example, a New York event may be 5pm UTC at start of March, 4pm UTC mid-way through March (as event's timezone's DST shifted) -- while in New York it stays at 1pm -- while in say London it is 5pm at start of March, 4pm mid-way through March, then back to 5pm in April (because the latter London DST kicked in, to pair up with the earlier New York DST).

Trying to trace timestamps through all the correct conversions when all these little shifts are happening is more than human working memory can hold ;-).

PDStig

2015-03-25 19:00

administrator   ~2662

Oh I bet, but I commend you for your hard work to try and get this working.

Issue History

Date Modified Username Field Change