View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 1796 | Composr | core_rich_media | public | 2015-02-08 01:32 | 2015-03-05 22:09 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 1796: Upgrade CKEditor kama skin | ||||
| Description | Kama looks dated on hi-dpi screens, as it doesn't support them properly. It probably looks worse on hi-dpi than normal-dpi, as the images have been pre-blown-up fairly badly. We should update Kama and to Retina ourselves and donate it back. data/ckeditor/skins/kama/icons_hidpi.png | ||||
| Additional Information | An alternative plan was to switch to moono: Switch to moono, as it supports hi-dpi (kama looks dated now). http://ckeditor.com/addon/moono We'll need to update our build-config.js. However, I think it is better we upgrade Kama. I like moono, but by upgrading Kama we give users choice (switching skins isn't too hard) -- not just in the Composr community, but also the wider CKEditor community. It would be nice to give something back. Kama is colourful, as opposed to the mono moono skin. | ||||
| Tags | Pseudo-addon: CKEditor | ||||
| Attach Tags | |||||
| Time estimation (hours) | 0.5 | ||||
| Sponsorship open | |||||
|
|
Thank you for the sponsorship Rishi :). I hope you're okay with the clarified direction here - upgrading Kama. Our designer should have some free time and does great icon work, so it is very viable for us to go in that direction. |
|
|
Happy to be part of this :) Yes, this direction is fine, though I'll want to learn how to switch between skins so that I can compare both, see how they are on the eyes. |
|
|
Potentially we can add it to the new WYSIWYG tutorial, how to switch out skins. The office skin they have is very nice too. |
|
|
We should do retina for our own icons, but may need changes in ckeditor for it: http://dev.ckeditor.com/ticket/12932 |
|
|
I've had a play with skins. Switching skins is pretty easy already. I tried a few and like kama (what we have now), moono, and moonocolor. On testing the office skin looked out of place. 1) place the skin files in data/ckeditor/skins/ 2) edit the WYSIWYG_SETTINGS.tpl template change.. var editor_settings={ to: var editor_settings={ skin: 'moono', (i.e. add a line, obviously use the correct skin name) 3) empty the template cache manually if you didn't do the template edit from within Composr (JAVASCRIPT_EDITING.tpl needs decacheing). |
|
|
We've done the superset of this. The new default theme will be moono. We have submitted Retina support for Kama upstream: http://dev.ckeditor.com/ticket/12918 Generally we've worked on improved documentation, including how to switch skins. So the new Kama could be dropped in when upstream releases it. I don't want us to fork CKEditor to get the improved Kama in immediately, I'd rather do this via a cooperative model. |
|
|
Thanks Chris. I followed the instructions above for using moono, however the area comes up blank. No editor interface at all. |
|
|
Ah. It's a version issue. Your CkEditor is 3.6, the earliest Moono release is 4.0. Once we deliver all the editor updates in one go, we'll do it with a reasonably recent CKEditor version too. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-05-06 23:44 | Chris Graham | Tag Renamed | CKEditor => Pseudo-addon: CKEditor |
