View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 1786 | Composr | calendar | public | 2015-01-31 17:16 | 2015-03-13 11:23 |
| Reporter | PDStig | Assigned To | Chris Graham | ||
| Priority | normal | Severity | @40@ | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 1786: Better implementation of the syndication of new calendar events | ||||
| Description | Calendar events, when added and then syndicated, only display the time in syndication messages. This poses several issues: 1. It does not display start date/time and end date/time, which is probably most ideal. 2. The time is in GMT and not necessarily in the timezone set by Composr or PHP. 3. Perhaps add text describing the recurrance as well, if set. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| Attached Files | |||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
1/2 aren't correct, however there are other bugs that have confused you. In particular, an "all day event" is the default, and for this no time will show - but the UI is confusing as the time is locked but not greyed out. There are also some bugs/inconsistencies converting timezones. For 3 I will do a simple change, so it says it recurs regularly, but it won't try and go into detail (as that could take hours, there are so many recurring options and currently no code to convert them into an English explanation). |
|
|
Committed changes in https://github.com/chrisgraham/Composr/commit/1427cbddde221bb16a6b285da0e5466a90ba9051 |
|
|
you might be thinking of the UI for adding a new event. I was talking about syndication, eg. What gets sent out over Twitter and the activity feed. |
|
|
I know. But the time is/was included. I think you just didn't realise an event had no time, because it's not clear in the UI that an all-day event has no time. The other possibility for no time showing is if you do a long event (multi-day), in which case it trims it to just show dates. |
|
|
Thats weird. In syndicated messages I only ever see the time. It doesn't give out the date no matter if its recurring, one time, or all day. |
|
|
Oh I misread, you said date was missing not time. There was a bug where an event with a start and no end just showed a random number, that could have been it. Regardless, we'll discuss in circles unless you are re-testing with the new code -- so please either grab changed files from the git revision above, or wait until the next patch release. |
|
|
Oh my bad. I meant date was missing in syndication. When I get home ill apply git commit and let you know what happens. |
|
|
No my bad, I misread, then I miswrote my reply above (which I've now edited :P). I'm juggling too many tasks at once... |
|
|
It's fine. It's Monday ^^ Anyway I applied git changes and I'm liking the output. It displays only what's needed but still displays what's needed... dates and times and whether or not it recurs. |
|
|
Hey Chris. Calendar syndication I think is messed up again as of 9.0.18: Lovinity has added an event, The Wonderbronies (happening on 12-2 AM (2 hours) and recurs regularly) This is what the Activity feed picked up from Calendar events. This is supposed to be an event that begins March 29 8pm-10pm (EDT) and recurs weekly. But the syndication only pushed the time, not the date. |
|
|
Automated response: Calendar date range display is sub-optimal 1) We need to show the date for a single-day event, not just times. 2) We don't want to strip :00 minutes from the time if we aren't able to do it for *both* start and end time (otherwise it gets confusing) 3) We should say what timezone we are displaying in |
|
|
Fixed in git commit 3fa547e (https://github.com/chrisgraham/Composr/commit/3fa547e - link will become active once code pushed to github) A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). |
|
|
Looks good so far. Only problem is the time and date still displays in UTC on the syndication even if, for example in my case, I have it in EDT. Lovinity has added an event, The Wonderbronies (happening on Monday 30th March 2015, 12 - 2 AM (UTC-04:00) Eastern Time (US & Canada), New York (2 hours) and recurs regularly) (should be March 29 8pm - 10pm) |
|
|
Ok, that was not intentional. I have updated cms_calendar.php in the hotfix and my tests show it working correctly now. Sorry for the need for all this back and forth, the calendar code always confuses the hell out of me, so many conversions. |
|
|
Alright. Thanks Chris. And don't worry... I can only imagine the pain the calendar module causes, especially when it comes to recurrence patterns and handling Daylight Savings Time. |
