View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 1737 | Composr | core_rich_media | public | 2014-12-10 19:38 | 2015-02-13 18:45 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 1737: Improve WYSIWYG spellchecking | ||||
| Description | CKEditor takes over the right-click menu ("context menu"), so you have to hold ctrl when right clicking misspelled words to get back to the browser menu. Users don't understand this 99% of the time. There is no browser API for accessing browser's inbuilt spellchecking. It has to be through the context menu, which we cannot extend or scan. We do need CKEditor's context menu as it is used for table editing. CKEditors spellchecker is horrible adware, and it would be much better architecturally to simply use the standard system spellchecker. This is why we disable the CKEditor spellchecker. Therefore I suggest we add our own spellchecker button to the toolbar. Clicking this button disables the CKEditor context menu, turns on the squiggly underlines, and alerts the user right clicking now works. Clicking it again reverses this. (By default we therefore don't show the squiggly underlines - currently we do by default) | ||||
| Steps To Reproduce | To do this we will need to edit the CKEditor contextmenu plugin, specifically extending this bit to recognise the state of our spellchecker: if ( nativeContextMenuOnCtrl && isCtrlKeyDown ) return; | ||||
| Tags | Pseudo-addon: CKEditor | ||||
| Attach Tags | |||||
| Time estimation (hours) | 2 | ||||
| Sponsorship open | |||||
|
|
Now I have read you comments in detail from a previous ticket it all makes sense.Will review and decide if we fund the project. |
|
|
Note that by allowing the context menu to come back, we can also allow native copy&paste, which could be more useful than the copy/paste buttons in the CKEditor toolbar which are subject to JavaScript security restriction. |
|
|
Thanks Jason for sponsoring this |
|
|
Interestingly doing a lot more testing suggests Chrome handles the spell checking quite well.You simply right click on the words with squiggly lines and the Chrome spell checker shows the corrected word and corrects. HOWEVER Firefox is awful and simply brings up the cut/copy/paste dialog box. If all browsers worked like Chrome it would be great... |
|
|
Quick note, we need to update tutorial(s)/FAQ when this change is made. |
|
|
This is now implemented, and I'm very happy with the result :). Simple and effective. Works on Safari/Firefox/Chrome/IE10/IE11 (IE9 doesn't support native spellcheck). Here's a quick screencast: http://screencast.com/t/MblAql67 Jing jumped the record frame about a bit near the end, try and ignore that. You'll get a sneak peak of v10 though. I am considering whether we should release this as a part of a v9 patch release. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-05-06 23:44 | Chris Graham | Tag Renamed | CKEditor => Pseudo-addon: CKEditor |
