View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 1472 | Composr | General / Uncategorised | public | 2013-12-18 15:32 | 2013-12-18 15:35 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | high | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 9.0.10 | ||||
| Summary | 1472: Keep parameters not propagated in IE11 | ||||
| Description | If you set keep parameters, they will not propagate across URL clicks, unless IE11 is in compatibility mode. Technical explanation follows... This is a set of old Composr bugs that did not surface until IE11 was released: 1) get_bot_type function not caching its "quick exit" optimisation result, designed so we quickly identify that known browsers are not bots (a bug, and a very small performance issue) 2) Skipping of keep parameters for bots using the wrong global cache value, relying on bug 1 to work (again, an optimisation - reading straight from cached value, but this time incorrectly treating the lack of cached value as meaning 'not a bot') Plus: 3) IE11 uses Trident instead of MSIE in the user-agent string, and we must now recognise this in our browser detection code. Because IE11 was not slipstreamed as a known non-bot, the correct global variable setting was set, and hence the incorrect value check triggered the code to work a if IE11 was a bot. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| Attached Files | |||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
Fixed in git commit edef838 (https://github.com/chrisgraham/Composr/commit/edef838 - link will become active once code pushed) A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
