Pagination Error

Hey Composr's!

Had this one around for a wee while but hadn't gotten around to asking. Anyone experienced this bad boy:



100% recreatable on every page pagination is used. Sorry for the delay in reporting; it's been around for the last 5+ releases or so. I get it on a fresh (read: not yet mangled by me ) installation as well. Unfortunately my Javascript sux worse than my PHP so I'm not much help in troubleshooting.

Thanx!

A little further: using the chainsaw approach, removing all instances of WRAPPER_ID from AJAX_PAGINATION.tpl stops the error from happening on comcode pages without seeming to affect the ability to toggle through entries. This action however fires a syntax error in the member profile activities screen. Interesting part: restoring AJAX_PAGINATION.tpl starts the error again on comcode pages but there is no error at all from member profile activities screen even with the pagination thingy loading at the bottom of the page.

Hey,

Do you have an overridden template that is including AJAX_PAGINATION?
I think there was a bug with this a while back, but it was fixed.

Anything including the template should be passing a WRAPPER_ID, e.g.

Hey Chris! As far as I know and can tell from date stamps the only one ever used was the one included with the default template. Interesting new happenstance: playing around with something different last night saw me starting with a 10.0.18 package and voila, the error was gone. Upon applying the upgrade to 10.0.22 it returned. I copied the AJAX file from the .18 package default theme overwriting .22 default theme version and the error disappeared again. The biggest difference I can see in the files is the reference to wrapper_id in that the .18 package calls whereas the .22 package is

Hi,

Sorry for the delay in replying, this got stuck too far down my todo list.

I'm not convinced there's an active bug here, I think I didn't communicate what I meant clearly enough.

Maybe this commit will clarify what has happened:
https://github.com/ocproducts/composr/commit/71c30fb108897aecb20eb310cbd3bfb516e5c14f

Before Jul 31, 2018, there was an issue whereby nested paginations would mess up, because we were setting IDs based on shared variables (creating a conflict). So I instead switched it to so each template would assign a template-specific ID.

Any of the changed templates overridden from an earlier patch would have lost compatibility at this point. I suspect you have one or more of them overridden.

The Tempcode that loads up AJAX_PAGINATION passes through WRAPPER_ID now, as used by the new version of that template.

I know this is something that is affecting the themes i made, so will go through them all and update with the above. I will also include the instructions on how to manually fix them for those who have further customised their theme.

Paul Flavel said

I know this is something that is affecting the themes i made, so will go through them all and update with the above. I will also include the instructions on how to manually fix them for those who have further customised their theme.

From “Post #5573”, 9th Oct 2019

Sorry for the inconvenience, thanks for doing that.

Not an issue at all. Very easy fix.