#735 - Blocks may cache incorrectly

Identifier #735
Issue type Minor issue (breaks specific functionality)
Title Blocks may cache incorrectly
Status Completed
Handling member Chris Graham
Version 8.1.3
Addon General / Uncategorised
Description There is a design conflict in how block caching is managed.

Some blocks do not have cacheing for intentional reasons. An example is the side_personal_stats block. However, if cache="1" is explicitly set for the block, this is overridden and caching does happen.

The "add block" assistant allows adding of blocks with all the default settings explicitly pre-populated.

Hence manually added blocks without caching, would be cached by default.

To fix this we will change it so that cache="1" does not cache if caching is not defined. If you want to force caching for a block that does not normally have it (which is a bad idea in general!), use the quick_cache="1" setting (which also stops it storing as Tempcode).


Additionally, there is a bug where viewing polls as standalone would produce an error. This patch will fix that also.
Steps to reproduce

Funded? No
Commits

26b75b0
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated