#6272 - When replying, getting the CAPTCHA wrong cancels out the reply functionality
-
By jacobgkau
- Added
- 11 views
| Identifier | #6272 |
|---|---|
| Issue type | Trivial issue (does not break functionality) |
| Title | When replying, getting the CAPTCHA wrong cancels out the reply functionality |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | PDStig |
| Version | 11 beta8 |
| Addon | core_feedback_features |
| Description | When replying to a threaded post, if you get the CAPTCHA wrong, the comment instead gets posted top-level. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
The dynamically-injected POST parameter "parent_id" which controls what we are replying to is not re-processed when going back in navigation. This hotfix attempts to fix that, but has not yet been thoroughly tested.
The issue will be marked resolved when confirmed the bug has been fixed.
- If an error occurs in AJAX commenting, we do *not* try to re-submit the comment form with a traditional request because sometimes this will cause more issues (re-triggering bad errors, hack attacks, loops, etc) and will sometimes hide the error that occurred (and pops up in an overlay)
- Comments posting form missing "useCaptcha" parameter which means the CAPTCHA was not being checked through AJAX for correctness before the comment gets posted.
With all of these fixes, this should indirectly fix the main bug because in no instance would the page navigate away during an error and cause the parent_id to go missing (and thus a comment becoming top-level).