#6204 - Upgrader does not extract new images for default theme
-
By PDStig
- Added
- 11 views
| Identifier | #6204 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | Upgrader does not extract new images for default theme |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | PDStig |
| Version | 11 beta7 |
| Addon | core_upgrader |
| Description | While the images for the default theme are bundled in the releases, the upgrader does not actually extract some of them, leading to missing news and calendar icons in a v10 -> v11 upgrade. This might be part of a larger extraction issue. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
There were a couple issues with the file upgrader causing it to sometimes skip over files which should be extracted:
1. Files which belong to multiple addons (e.g. core_all_icons) might get mapped to the addon which is not installed, causing the file to not get extracted even if the other addon is installed. This hotfix ensures $found will never match to an addon which is not installed. That way, if a file belongs to multiple addons, it will get extracted if at least one of them are installed.
2. Directory checking is improved. We will now check TAR directories to see if any installed addon files use it. If so, we ensure the directory gets created.
A couple other minor fixes were also made:
- If an omni-upgrader generated by the release tools exists in data_custom, it will be auto-filled in the URL.
- Fixed an issue where if not using iframe, dry-run will not list files to be extracted.