#5717 - Adjust upgrader and install.php to solely use minikernel.php and relevant templates

  • By
  • Added
  • 7 views
Identifier #5717
Issue type Feature request or suggestion
Title Adjust upgrader and install.php to solely use minikernel.php and relevant templates
Status Closed (rejected)
Tags

Roadmap: v11 (custom)

Handling member Deleted
Addon installer
Description Make upgrading between versions easier and more streamlined.

a) install.php, upgrader.php, and data/upgrader2.php, should generally never use source files outside of itself, minikernel.php, crypt_master.php, and any tpl files starting with INSTALLER_. Make this a coding standard in addition to incorporating it.

*Exception: upgrader.php can load in any additional source files it needs after step 4 when all updated files have been transferred.
*Exception: install.php can load in any additional source files it needs after having transferred / extracted all the files it needs.

b) upgrader.php, upon transferring new and updated files, should immediately extract the following files if present instead of deferring to data/upgrader2.php:
- sources/minikernel.php
- sources/crypt_master.php (this already happens)
- upgrader.php
- data/upgrader2.php (this already happens)
- any templates starting with INSTALLER_ or whatever is used for the upgrader (but only if we also had to extract upgrader.php; these updated templates are otherwise not needed right away)

c) If the upgrader had to extract an updated upgrader.php, then it should forcefully terminate before starting up data/upgrader2.php / the secondary stage of transferring files, and require the end user to reload upgrader.php to run the updated upgrader. Perhaps just display a more options button.
Steps to reproduce

Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated