#5597 - Remove all "var" declarations

By PDStig
Added 6th Feb 2024, 10:08 PM
1 view

Identifier	#5597
Issue type	Feature request or suggestion
Title	Remove all "var" declarations
Status	Closed (no changes needed)
Tags	Roadmap: Over the horizon (custom) Roadmap: v11 partial implementation (custom) Type: Standards compliance (custom)
Handling member	Deleted
Addon	General / Uncategorised
Description	PSR-12 does not allow declaring variables by using "var". Remove these, and make code quality checker pick up on these. They should be set to private/protected or public.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 10th Feb 2024, 2:48 PM

We do this? I thought it only happened in 3rd party code, and I don't think we should be upgrading coding standards on third party code unless PHP really isn't able to run it anymore (and if resyncing with an updated dependency or a replacement option is not feasible).

By Guest posted 10th Feb 2024, 2:58 PM

Yes there are a few files that have this. I think I already fixed the few instances that were left over in modules, but there are still a few instances in code_editor.php.

EDIT: false alarm code_editor is JavaScript. It looks like we don't have any more vars to fix in v11.

By Guest posted 10th Feb 2024, 11:36 PM

There aren't any more vars in v11 that need fixing. Closing the issue.