#5341 - protect_database_details option

By Chris Graham
Added 20th Feb 2023, 9:24 PM
1 view

Identifier	#5341
Issue type	Feature request or suggestion
Title	protect_database_details option
Status	Open
Tags	Has Patch (custom) Roadmap: Over the horizon (custom) Type: Security (custom)
Handling member	Deleted
Addon	core_database_drivers
Description	Add a new installation option that, if set, hides details of database errors so they can only be found by looking into the stack trace (which is access-protected).
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 20th Feb 2023, 9:24 PM

Attachment

By Guest posted 20th Feb 2023, 9:55 PM

IMO this should be on by default because sensitive / private information could be leaked.

By Guest posted 21st Feb 2023, 9:51 AM

Part of me agrees, but I am also concerned that it will degrade the quality of bug reports, leading to people reporting very generic database error messages. Perhaps my concern can be met by ensuring the error messages get a coordinating ID against what goes into the telemetry (assuming the user has that enabled). We'd also need to make sure that users of sites can report errors in clear way, because the error log doesn't have stack traces and I'm not sure if the admins will have error notifications turned on. Maybe we need to consider coordinating IDs in the error log and automatically linking to some directory of dumped stack traces. We already have a system whereby error messages can be replaced with a generic error screen, with actual traces logged into a directory - perhaps that needs merging with these ideas.