#5189 - jumping comcode tag does not work on pages (but does in previews)

By PDStig
Added 21st Dec 2022, 1:00 PM
4 views

Identifier	#5189
Issue type	Minor issue (breaks specific functionality)
Title	jumping comcode tag does not work on pages (but does in previews)
Status	Completed
Handling member	Chris Graham
Addon	General / Uncategorised
Description	The jumping comcode tag does not work on the actual comcode page (but it does in previews). Seems the "parts" template parameter is not getting added, and I don't understand why. Everything checks out in comcode_renderer.php lines 1216-1231 ($_parts has the expected values in them).
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 21st Dec 2022, 8:05 PM

I can't reproduce this.

By Guest posted 22nd Dec 2022, 11:32 AM

Here's the div. "parts" is supposed to be an array parameter in the template (in this case, with 3 items), but it doesn't exist, causing a console error. It exists in the preview.

By Guest posted 22nd Dec 2022, 11:32 AM

By Guest posted 22nd Dec 2022, 8:38 PM

Fixed in https://gitlab.com/composr-foundation/composr/-/commit/6d7b7347778059991377d3053cf6bec2af4751ed
Very difficult bug. When a template was first compiled, Composr would detect various parameters were not used and not bind those parameters in the do_template call. However, parameters referenced in the PARAMS_JSON were not considered used.

Probably was a big bug happening in many places, surprised we only just found it.